Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 27, 2025

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR primarily focuses on enhancing the ContractSubscriptionsService, BackendWalletService, and contract reading functionalities, including improved schemas and error handling. It introduces new features such as webhookId, updates the readRequestQuerySchema, and refines the contract reading process.

Detailed summary

  • Added webhookId to ContractSubscriptionsService with detailed documentation.
  • Updated BackendWalletService to include an optional authorizationList with address and chainId.
  • Revised readRequestQuerySchema to include a full function signature and optional abi.
  • Enhanced error handling in readContract with improved method resolution.
  • Updated bigNumberReplacer to handle bigint types.
  • Added new tests for contract reading functionalities in read.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zeet-co
Copy link

zeet-co bot commented Mar 27, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://engine-cloud-core-dev-2at8-refact-a3c57d.chainsaw-dev.zeet.app before merging 😉

@zeet-co
Copy link

zeet-co bot commented Mar 27, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-refact-630946.engine-aws-usw2.zeet.app before merging 😉

@joaquim-verges joaquim-verges marked this pull request as ready for review March 27, 2025 21:01
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the Refactor_contract_read_route_to_use_thirdweb_v5 branch from f9f035b to 8f7fd7a Compare March 27, 2025 23:12
@joaquim-verges joaquim-verges merged commit b7a4bb7 into main Mar 27, 2025
8 checks passed
@joaquim-verges joaquim-verges deleted the Refactor_contract_read_route_to_use_thirdweb_v5 branch March 27, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants