Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 24, 2025

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR focuses on enhancing the signTypedData function to handle cases where the primaryType is not provided, allowing for automatic detection of the primary type. It also introduces tests to ensure the functionality works correctly in both scenarios.

Detailed summary

  • Added logic to detect primaryType in sign-typed-data.ts if not provided.
  • Updated the call to signTypedData to use the parsed primary type.
  • Introduced new tests in sign-typed-data.test.ts for signing typed data with and without a primary type.
  • Created a structured test data object for testing purposes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zeet-co
Copy link

zeet-co bot commented Apr 24, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-04-25--704c08.engine-aws-usw2.zeet.app before merging 😉

@joaquim-verges joaquim-verges marked this pull request as ready for review April 24, 2025 19:21
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges merged commit 84a0254 into main Apr 24, 2025
8 checks passed
@joaquim-verges joaquim-verges deleted the 04-25-detect_primary_type_if_missing_in_sign_typed_data_input branch April 24, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants