chore: allow querying status by query param #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're building your pull request over on Zeet. |
arcoraven
commented
May 2, 2025
| }, | ||
| wsHandler: async (connection: SocketStream, request) => { | ||
| const { queueId } = request.params; | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Removing websocket handler. Not used anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on removing WebSocket functionality from the server and updating transaction status routes. It replaces the
checkTxStatusfunction with two new routes that handle transaction status retrieval via query parameters.Detailed summary
withWebSocketmiddleware import and its usage insrc/server/index.ts.checkTxStatuswithgetTransactionStatusRouteinsrc/server/routes/transaction/status.ts.getTransactionStatusQueryParamRoutefor querying transaction status via query parameters.checkTxStatus.