-
Notifications
You must be signed in to change notification settings - Fork 105
Update thirdweb to 5.105.42 #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated dependency version in package.json: bumped thirdweb from ^5.100.1 to ^5.105.42. No source code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches🧪 Generate unit tests
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint
- GitHub Check: build
🔇 Additional comments (5)
package.json (5)
72-72: Dependency bump looks good.Straightforward version update to thirdweb; no other deps changed.
72-72: Lockfile is already consistent. yarn.lock entry forthirdweb@^5.105.42resolves to version 5.105.42, so no further action is needed.
72-72: Dual SDK check unnecessary
No@thirdweb-dev/sdkdependency or imports detected—onlythirdwebis declared in package.json. Suggestion isn’t applicable.Likely an incorrect or invalid review comment.
72-72: Verify Address type compatibility
thirdweb v5 may have widened viem’sAddresstype tostring, which can break strict-typed code. Run a full TypeScript build (npm install --save-dev typescriptif needed, thennpx tsc --noEmit) to confirm there are no regressions.
72-72: Runtime meets Node ≥18.6: Dockerfile uses node:18.20-slim (≥18.6), satisfying thirdweb v5 SDK requirement.
| "prom-client": "^15.1.3", | ||
| "superjson": "^2.2.1", | ||
| "thirdweb": "^5.100.1", | ||
| "thirdweb": "^5.105.42", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure viem/ethers compatibility and single-version dedupe.
thirdweb v5 works with viem and ethers; we already pin viem 2.22.17 in deps and resolutions and ethers v5. Confirm there’s no duplicate viem/ethers trees after the bump. (portal.thirdweb.com, github.com)
🏁 Script executed:
#!/bin/bash
# Explain dependency graph for potential duplicates
yarn why thirdweb viem ethers || true
# List any nested viem/ethers under thirdweb
fd -H node_modules | rg -nP '/(thirdweb|@thirdweb-dev)/' -n -C0 | rg -nP '/(viem|ethers)(/|@)' -n -C0 || trueLength of output: 142
🏁 Script executed:
#!/bin/bash
# Show why each package is installed
printf "\n=== yarn why thirdweb ===\n"
yarn why thirdweb || true
printf "\n=== yarn why viem ===\n"
yarn why viem || true
printf "\n=== yarn why ethers ===\n"
yarn why ethers || true
# List all installed versions of viem and ethers
printf "\n=== yarn list --pattern viem ===\n"
yarn list --pattern "viem" || true
printf "\n=== yarn list --pattern ethers ===\n"
yarn list --pattern "ethers" || true
# Find any nested viem/ethers module directories under node_modules
printf "\n=== Duplicate module directories ===\n"
find node_modules -type d | grep -E "/node_modules/(viem|ethers)$" || printf "No duplicate module dirs found\n"Length of output: 18042
Pin ethers to a single version via resolutions
Detected two ethers versions (5.7.2 at root vs. 5.5.1 under ethers-gcp-kms-signer). Add a resolutions override in package.json (e.g. "ethers": "5.7.2") and reinstall to force-dedupe.
🤖 Prompt for AI Agents
In package.json around line 72, multiple versions of ethers were detected (root
5.7.2 vs 5.5.1 under ethers-gcp-kms-signer); add a resolutions override to force
a single version (for example add a top-level "resolutions": { "ethers": "5.7.2"
}) and then reinstall and regenerate the lockfile (npm/yarn/pnpm install or yarn
install --check-files / yarn-deduplicate as appropriate) so the dependency is
deduped to the pinned version; if using npm, add an "overrides" entry instead of
"resolutions" with the same key/value and update the lockfile.

Changes
How this PR will be tested
Output
(Example: Screenshot/GIF for UI changes, cURL output for API changes)
PR-Codex overview
This PR updates various dependencies in the
package.jsonandyarn.lockfiles, including version upgrades and changes to specific packages to improve functionality and compatibility.Detailed summary
thirdwebfrom^5.100.1to^5.105.42.@emotion/styledfrom11.14.0to11.14.1.@radix-ui/react-dialogfrom1.1.10to1.1.14.@radix-ui/react-focus-scopefrom1.1.4to1.1.7.@radix-ui/react-tooltipfrom1.2.3to1.2.7.@tanstack/react-queryfrom5.74.4to5.81.5.@thirdweb-dev/enginefrom3.0.1to3.2.1.@thirdweb-dev/insightfrom1.0.0to1.1.1.@walletconnect/corefrom2.20.1to2.21.4.@walletconnect/sign-clientfrom2.20.1to2.21.4.@walletconnect/typesfrom2.20.1to2.21.4.@walletconnect/utilsfrom2.20.1to2.21.4.viemfrom2.28.1to2.33.2.zodfrom3.22.4to3.25.75.@msgpack/msgpackversion3.1.2and@scure/baseversion1.2.6.uint8arraysfrom3.1.0to3.1.1.Summary by CodeRabbit