Skip to content

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Oct 15, 2024

TL;DR

Improved block polling logic and updated storage interfaces for more precise block range handling.

What changed?

  • Modified Poller initialization to handle ForceFromBlock configuration more effectively.
  • Updated GetLastStagedBlockNumber method in storage interfaces to include a rangeStart parameter.
  • Adjusted ClickHouse and memory storage implementations to support the new rangeStart parameter.
  • Updated mock storage interface to reflect the changes in the GetLastStagedBlockNumber method.

How to test?

  1. Verify that the poller initializes correctly with different ForceFromBlock configurations.
  2. Test the GetLastStagedBlockNumber method with various range start and end values.
  3. Ensure that the ClickHouse and memory storage implementations correctly filter blocks within the specified range.
  4. Update and run existing tests that use the mock storage interface to accommodate the new parameter.

Why make this change?

This change improves the flexibility and precision of block polling and storage operations. By introducing a rangeStart parameter, we can more accurately retrieve and manage block data within specific ranges. This is particularly useful for scenarios where we need to re-poll from a specific start block or handle gaps in block data more effectively.

@iuwqyir iuwqyir changed the title add lower range for finding staged block number Improve poller block range handling and staging data retrieval Oct 15, 2024
Copy link
Contributor Author

iuwqyir commented Oct 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iuwqyir and the rest of your teammates on Graphite Graphite

@iuwqyir iuwqyir marked this pull request as ready for review October 15, 2024 21:32
@iuwqyir iuwqyir merged commit 15948f0 into main Oct 15, 2024
5 checks passed
@iuwqyir iuwqyir deleted the 10-16-add_lower_range_for_finding_staged_block_number branch October 15, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants