-
Notifications
You must be signed in to change notification settings - Fork 28
Enable aggregates and group_by #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @catalyst17 and the rest of your teammates on |
d22e74d to
8e4c390
Compare
bd55ca1 to
a55695d
Compare
2922b7c to
8acc2cc
Compare
8acc2cc to
7698103
Compare
iuwqyir
approved these changes
Oct 25, 2024
Contributor
Author
7698103 to
3e4e848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

TL;DR
Enhanced the query functionality to support multiple grouping fields and aggregations, with improved type handling for ClickHouse data types.
What changed?
GroupByfield inQueryParamsto accept an array of strings instead of a single stringGetAggregationsmethod to handle grouped and aggregated queries separatelyAggregationsfield inQueryResponseto use[]map[string]interface{}for flexible result handlingHow to test?
Why make this change?
This enhancement provides more robust support for data analysis by properly handling grouped queries and aggregations. The improved type mapping system ensures accurate data representation when working with ClickHouse's various data types, while maintaining clean separation between regular queries and aggregations.