Skip to content

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Oct 24, 2024

TL;DR

Changed block gap handling to poll missing blocks instead of marking them as failures.

What changed?

  • Replaced the block failure recording mechanism in handleGap with a new polling approach
  • Created a new BoundlessPoller that can poll arbitrary block ranges
  • Refactored the Poller to extract common functionality into BoundlessPoller
  • Updated tests to reflect the new polling behavior

How to test?

  1. Run the indexer with a gap in block sequence
  2. Verify that missing blocks are now polled and processed
  3. Confirm that blocks are properly indexed instead of being marked as failures
  4. Run unit tests to verify the new gap handling behavior

Why make this change?

The previous implementation would mark missing blocks as failures without attempting to retrieve them. This new approach actively tries to fetch and process missing blocks, improving indexing speed

@iuwqyir iuwqyir changed the title trigger polling when gap is detected Poll missing blocks in gap handler Oct 24, 2024
Copy link
Contributor Author

iuwqyir commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iuwqyir and the rest of your teammates on Graphite Graphite

@iuwqyir iuwqyir marked this pull request as ready for review October 24, 2024 13:14
Copy link
Contributor

with this new approach, under which conditions blocks can still be marked as failed?

Copy link
Contributor Author

iuwqyir commented Oct 25, 2024

Merge activity

  • Oct 25, 9:17 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 25, 9:17 AM EDT: A user merged this pull request with Graphite.

@iuwqyir iuwqyir merged commit 31df1e0 into main Oct 25, 2024
5 checks passed
@iuwqyir iuwqyir deleted the 10-24-trigger_polling_when_gap_is_detected branch October 25, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants