Skip to content

Conversation

@vernonjohnson
Copy link
Contributor

@vernonjohnson vernonjohnson commented Mar 6, 2025

@iuwqyir

  • Added the balances endpoint w/out type in path
  • Added support for token_ids param in balances and holders endpoints (e.g., "1,2,3")
  • Made token type optional for balances endpoint, so you can get all tokens

@vernonjohnson vernonjohnson changed the title fix: add token ids filter feat: support token id in balances and holders endpoints Mar 6, 2025
@vernonjohnson vernonjohnson requested a review from iuwqyir March 6, 2025 18:20
@vernonjohnson
Copy link
Contributor Author

@iuwqyir I think for token type we should make it an array? so you could do erc1155,erc721 in one query?

@iuwqyir
Copy link
Contributor

iuwqyir commented Mar 6, 2025

@iuwqyir I think for token type we should make it an array? so you could do erc1155,erc721 in one query?

Yes, that would be good

Copy link
Contributor

@iuwqyir iuwqyir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, just the 2 nits

@vernonjohnson vernonjohnson requested a review from a team March 6, 2025 19:54
@vernonjohnson vernonjohnson merged commit f33e3df into main Mar 6, 2025
4 checks passed
@vernonjohnson vernonjohnson deleted the vt-token-balances-updates branch March 6, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants