Make inserts and reorg handling atomic #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

TL;DR
Implemented atomic block data operations to improve data consistency during reorgs and commits.
What changed?
ReplaceBlockDatamethod in ClickHouse storage that atomically handles both deletion and insertion of block dataDeleteBlockDataandInsertBlockDatacalls in the reorg handler with a single atomicReplaceBlockDatacallinserts_null_tableto store block data in a denormalized formatHow to test?
Why make this change?
The previous implementation had a race condition where block data could be inconsistent during reorgs. If the process failed between deleting old data and inserting new data, the database would be left in an inconsistent state. This change makes the replace operation atomic, ensuring data consistency even if failures occur.
Additionally, by ensuring data is saved to storage before publishing to Kafka, we prevent situations where consumers might receive notifications about data that isn't yet available in the database.