Skip to content

add possibility to poll without saving #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

add possibility to poll without saving #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 73 additions & 46 deletions internal/orchestrator/poller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,27 @@ func (p *Poller) Start(ctx context.Context) {
}

func (p *Poller) Poll(ctx context.Context, blockNumbers []*big.Int) (lastPolledBlock *big.Int) {
blockData, failedResults := p.PollWithoutSaving(ctx, blockNumbers)
if len(blockData) > 0 || len(failedResults) > 0 {
p.StageResults(blockData, failedResults)
}

var highestBlockNumber *big.Int
if len(blockData) > 0 {
highestBlockNumber = blockData[0].Block.Number
for _, block := range blockData {
if block.Block.Number.Cmp(highestBlockNumber) > 0 {
highestBlockNumber = new(big.Int).Set(block.Block.Number)
}
}
}
return highestBlockNumber
}

func (p *Poller) PollWithoutSaving(ctx context.Context, blockNumbers []*big.Int) ([]common.BlockData, []rpc.GetFullBlockResult) {
if len(blockNumbers) < 1 {
log.Debug().Msg("No blocks to poll, skipping")
return
return nil, nil
}
endBlock := blockNumbers[len(blockNumbers)-1]
if endBlock != nil {
Expand All @@ -180,8 +198,60 @@ func (p *Poller) Poll(ctx context.Context, blockNumbers []*big.Int) (lastPolledB

worker := worker.NewWorker(p.rpc)
results := worker.Run(ctx, blockNumbers)
p.handleWorkerResults(results)
return endBlock
blockData, failedResults := p.convertPollResultsToBlockData(results)
return blockData, failedResults
}

func (p *Poller) convertPollResultsToBlockData(results []rpc.GetFullBlockResult) ([]common.BlockData, []rpc.GetFullBlockResult) {
var successfulResults []rpc.GetFullBlockResult
var failedResults []rpc.GetFullBlockResult

for _, result := range results {
if result.Error != nil {
bn := "<unknown>"
if result.BlockNumber != nil {
bn = result.BlockNumber.String()
}
log.Warn().Err(result.Error).Msgf("Error fetching block data for block %s", bn)
failedResults = append(failedResults, result)
} else {
successfulResults = append(successfulResults, result)
}
}

blockData := make([]common.BlockData, 0, len(successfulResults))
for _, result := range successfulResults {
blockData = append(blockData, common.BlockData{
Block: result.Data.Block,
Logs: result.Data.Logs,
Transactions: result.Data.Transactions,
Traces: result.Data.Traces,
})
}
return blockData, failedResults
}

func (p *Poller) StageResults(blockData []common.BlockData, failedResults []rpc.GetFullBlockResult) {
startTime := time.Now()
metrics.PolledBatchSize.Set(float64(len(blockData)))
if len(blockData) > 0 {
if err := p.storage.StagingStorage.InsertStagingData(blockData); err != nil {
e := fmt.Errorf("error inserting block data: %v", err)
log.Error().Err(e)
for _, result := range blockData {
failedResults = append(failedResults, rpc.GetFullBlockResult{
BlockNumber: result.Block.Number,
Error: e,
})
}
}
}
log.Debug().Str("metric", "staging_insert_duration").Msgf("StagingStorage.InsertStagingData duration: %f", time.Since(startTime).Seconds())
metrics.StagingInsertDuration.Observe(time.Since(startTime).Seconds())

if len(failedResults) > 0 {
p.handleBlockFailures(failedResults)
}
}

func (p *Poller) reachedPollLimit(blockNumber *big.Int) bool {
Expand Down Expand Up @@ -230,49 +300,6 @@ func (p *Poller) createBlockNumbersForRange(startBlock *big.Int, endBlock *big.I
return blockNumbers
}

func (p *Poller) handleWorkerResults(results []rpc.GetFullBlockResult) {
var successfulResults []rpc.GetFullBlockResult
var failedResults []rpc.GetFullBlockResult

for _, result := range results {
if result.Error != nil {
log.Warn().Err(result.Error).Msgf("Error fetching block data for block %s", result.BlockNumber.String())
failedResults = append(failedResults, result)
} else {
successfulResults = append(successfulResults, result)
}
}

blockData := make([]common.BlockData, 0, len(successfulResults))
for _, result := range successfulResults {
blockData = append(blockData, common.BlockData{
Block: result.Data.Block,
Logs: result.Data.Logs,
Transactions: result.Data.Transactions,
Traces: result.Data.Traces,
})
}

startTime := time.Now()
if err := p.storage.StagingStorage.InsertStagingData(blockData); err != nil {
e := fmt.Errorf("error inserting block data: %v", err)
log.Error().Err(e)
for _, result := range successfulResults {
failedResults = append(failedResults, rpc.GetFullBlockResult{
BlockNumber: result.BlockNumber,
Error: e,
})
}
metrics.PolledBatchSize.Set(float64(len(blockData)))
}
log.Debug().Str("metric", "staging_insert_duration").Msgf("StagingStorage.InsertStagingData duration: %f", time.Since(startTime).Seconds())
metrics.StagingInsertDuration.Observe(time.Since(startTime).Seconds())

if len(failedResults) > 0 {
p.handleBlockFailures(failedResults)
}
}

func (p *Poller) handleBlockFailures(results []rpc.GetFullBlockResult) {
var blockFailures []common.BlockFailure
for _, result := range results {
Expand Down