Skip to content

postgres async delete #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

postgres async delete #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions internal/storage/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,13 @@ func (p *PostgresConnector) DeleteBlockFailures(failures []common.BlockFailure)
args = append(args, failure.ChainId.String(), failure.BlockNumber.String())
}

query := fmt.Sprintf(`DELETE FROM block_failures
WHERE (chain_id, block_number) IN (%s)`, strings.Join(tuples, ","))
query := fmt.Sprintf(`DELETE FROM block_failures
WHERE ctid IN (
SELECT ctid
FROM block_failures
WHERE (chain_id, block_number) IN (%s)
FOR UPDATE SKIP LOCKED
)`, strings.Join(tuples, ","))

_, err := p.db.Exec(query, args...)
return err
Expand Down Expand Up @@ -342,8 +347,13 @@ func (p *PostgresConnector) DeleteStagingData(data []common.BlockData) error {
args = append(args, blockData.Block.ChainId.String(), blockData.Block.Number.String())
}

query := fmt.Sprintf(`DELETE FROM block_data
WHERE (chain_id, block_number) IN (%s)`, strings.Join(tuples, ","))
query := fmt.Sprintf(`DELETE FROM block_data
WHERE ctid IN (
SELECT ctid
FROM block_failures
WHERE (chain_id, block_number) IN (%s)
FOR UPDATE SKIP LOCKED
)`, strings.Join(tuples, ","))

_, err := p.db.Exec(query, args...)
return err
Expand Down Expand Up @@ -422,7 +432,14 @@ func (p *PostgresConnector) GetLastStagedBlockNumber(chainId *big.Int, rangeStar
}

func (p *PostgresConnector) DeleteOlderThan(chainId *big.Int, blockNumber *big.Int) error {
query := `DELETE FROM block_data WHERE chain_id = $1 AND block_number <= $2`
query := `DELETE FROM block_data
WHERE ctid IN (
SELECT ctid
FROM block_data
WHERE chain_id = $1
AND block_number <= $2
FOR UPDATE SKIP LOCKED
)`
_, err := p.db.Exec(query, chainId.String(), blockNumber.String())
return err
}
Expand Down