Skip to content

Update s3 connector timeout #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

Update s3 connector timeout #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,10 @@ func init() {
rootCmd.PersistentFlags().String("migrator-destination-s3-secretAccessKey", "", "S3 secret access key for migrator destination")
rootCmd.PersistentFlags().String("migrator-destination-s3-endpoint", "", "S3 endpoint URL for migrator destination")
rootCmd.PersistentFlags().String("migrator-destination-s3-format", "parquet", "S3 storage format for migrator destination")
rootCmd.PersistentFlags().Int64("migrator-destination-s3-bufferSizeMB", 512, "S3 buffer size in MB before flush for migrator destination")
rootCmd.PersistentFlags().Int("migrator-destination-s3-bufferTimeoutSeconds", 300, "S3 buffer timeout in seconds before flush for migrator destination")
rootCmd.PersistentFlags().Int64("migrator-destination-s3-bufferSizeMB", 0, "S3 buffer size in MB before flush for migrator destination")
rootCmd.PersistentFlags().Int("migrator-destination-s3-bufferTimeoutSeconds", 0, "S3 buffer timeout in seconds before flush for migrator destination")
rootCmd.PersistentFlags().Int("migrator-destination-s3-maxBlocksPerFile", 0, "S3 max blocks per file for migrator destination")
rootCmd.PersistentFlags().Uint("migrator-batchSize", 2000, "Batch size for storage operations in migrator")
rootCmd.PersistentFlags().Uint("migrator-batchSize", 0, "Batch size for storage operations in migrator")
rootCmd.PersistentFlags().Uint("migrator-startBlock", 0, "Start block for migration")
rootCmd.PersistentFlags().Uint("migrator-endBlock", 0, "End block for migration")
rootCmd.PersistentFlags().Uint("migrator-workerCount", 0, "Worker count for migration")
Expand Down
5 changes: 2 additions & 3 deletions internal/storage/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,11 @@ func NewS3Connector(cfg *config.S3StorageConfig) (*S3Connector, error) {
}
}

// Set buffer defaults
if cfg.BufferSize == 0 {
cfg.BufferSize = 1024 // 1GB default
cfg.BufferSize = 512 // 512MB default
}
if cfg.BufferTimeout == 0 {
cfg.BufferTimeout = 300 // 5 minutes default
cfg.BufferTimeout = 1 * 60 * 60 // 1 hour in seconds default
}

// Create formatter based on format
Expand Down