Update error messages

[jakeloo]

Summary by CodeRabbit

• Refactor
  • Standardized error handling for in-progress and no-new-data conditions, providing consistent behavior when a requested block range is already being processed.
• Chores
  • Reduced log noise by suppressing expected-condition logs and emitting detailed messages only for actionable errors.
  • Improved log messages to include affected block ranges when relevant, aiding faster diagnostics without overwhelming routine operation logs.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Standardized error handling in the orchestrator poller by introducing a sentinel error for in-progress block ranges, updating poll and logging logic to return/suppress specific errors, and adjusting Request and processBatch to reduce log output for expected conditions.

Changes

Cohort / File(s)	Summary
Orchestrator poller error handling internal/orchestrator/poller.go	Added public sentinel ErrBlocksProcessed. poll returns ErrBlocksProcessed when range already processing. Request() suppresses logs for ErrBlocksProcessed and ErrNoNewBlocks, returning nil on these. processBatch() logs only non-sentinel errors, including block range context when available.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant P as Poller
  participant B as BatchProcessor

  C->>P: Request(blockRange)
  activate P
  P->>P: poll(blockRange)
  alt range already processing
    P-->>C: ErrBlocksProcessed (suppressed, returns nil)
  else no new blocks
    P-->>C: ErrNoNewBlocks (suppressed, returns nil)
  else ready to process
    P->>B: processBatch(blockRange)
    alt processing error (non-sentinel)
      B-->>P: error
      P-->>C: error (logged with range)
    else success
      B-->>P: ok
      P-->>C: ok
    end
  end
  deactivate P

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b6fdc97 and 888fa14.

📒 Files selected for processing (1)

• internal/orchestrator/poller.go (4 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jl/fix-error-msg

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.