feat(sdk): migrates signTypedData to Ox

Author: gregfromstl

packages/thirdweb/src/utils/signatures/sign-message.ts

@@ -9,8 +9,8 @@ import type { Prettify } from "../type-utils.js";
 type Message = Prettify<
   | string
   | {
-      raw: Hex | Uint8Array;
-    }
+    raw: Hex | Uint8Array;
+  }
 >;
 export type SignMessageOptions = {
   message: Message;
@@ -65,9 +65,9 @@ export function signMessage(
         ? options.message.raw
         : ox__Hex.fromString(options.message),
     );
-    return ox__Signature.toHex(
-      ox__Secp256k1.sign({ payload, privateKey: options.privateKey }),
-    );
+
+    const signature = ox__Secp256k1.sign({ payload, privateKey: options.privateKey }),
+    return ox__Signature.toHex(signature);
   }
   if ("account" in options) {
     const { message, account } = options;

packages/thirdweb/src/utils/signatures/sign-typed-data.ts

@@ -1,14 +1,15 @@
-import type { TypedData } from "abitype";
-import { type TypedDataDefinition, hashTypedData } from "viem";
 import type { Hex } from "../encoding/hex.js";
-import { parseTypedData } from "./helpers/parseTypedData.js";
-import { sign } from "./sign.js";
-import { signatureToHex } from "./signature-to-hex.js";
+import * as ox__TypedData from "ox/TypedData";
+import * as ox__Secp256k1 from "ox/Secp256k1";
+import * as ox__Hex from "ox/Hex";
+import * as ox__Signature from "ox/Signature";
 
 export type SignTypedDataOptions<
-  typedData extends TypedData | Record<string, unknown> = TypedData,
+  typedData extends
+  | ox__TypedData.TypedData
+  | Record<string, unknown> = ox__TypedData.TypedData,
   primaryType extends keyof typedData | "EIP712Domain" = keyof typedData,
-> = TypedDataDefinition<typedData, primaryType> & {
+> = ox__TypedData.Definition<typedData, primaryType> & {
   privateKey: Hex;
 };
 
@@ -28,17 +29,18 @@ export type SignTypedDataOptions<
  * @utils
  */
 export function signTypedData<
-  const typedData extends TypedData | Record<string, unknown>,
+  const typedData extends ox__TypedData.TypedData | Record<string, unknown>,
   primaryType extends keyof typedData | "EIP712Domain",
 >(options: SignTypedDataOptions<typedData, primaryType>): Hex {
   const { privateKey, ...typedData } =
     options as unknown as SignTypedDataOptions;
 
-  const parsedTypeData = parseTypedData(typedData);
+  const payload = ox__TypedData.getSignPayload(typedData);
 
-  const signature = sign({
-    hash: hashTypedData(parsedTypeData), // TODO: Implement native hashTypedData
-    privateKey,
+  const signature = ox__Secp256k1.sign({
+    payload,
+    privateKey: ox__Hex.fromString(privateKey),
   });
-  return signatureToHex(signature);
+
+  return ox__Signature.toHex(signature);
 }