Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 30, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR enhances the documentation for the claimTo function across three extensions: ERC1155, ERC20, and ERC721. It adds examples for basic usage and includes specific guidance for handling drops with allowlists.

Detailed summary

  • Added a "Basic usage" section with example code for claimTo in ERC1155, ERC20, and ERC721.
  • Included a section for drops with allowlists, explaining the need for the from parameter.
  • Provided example code for the claimTo function with the from parameter in all three extensions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Sep 30, 2024

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 96daa26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 9:19pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 9:19pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 9:19pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 9:19pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.91 KB (0%) 839 ms (0%) 3.7 s (+20.38% 🔺) 4.5 s
thirdweb (cjs) 101.54 KB (0%) 2.1 s (0%) 5.3 s (-2.24% 🔽) 7.4 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 205 ms (-2.06% 🔽) 301 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 136 ms (-3.72% 🔽) 146 ms
thirdweb/react (minimal + tree-shaking) 16.76 KB (0%) 336 ms (0%) 529 ms (-5.01% 🔽) 864 ms

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (a2ce5f5) to head (96daa26).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4849   +/-   ##
=======================================
  Coverage   47.59%   47.60%           
=======================================
  Files        1054     1054           
  Lines       57136    57136           
  Branches     3914     3916    +2     
=======================================
+ Hits        27195    27197    +2     
+ Misses      29253    29251    -2     
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a2ce5f5
packages 43.34% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...dweb/src/extensions/erc1155/drops/write/claimTo.ts 80.64% <ø> (ø)
...irdweb/src/extensions/erc20/drops/write/claimTo.ts 82.05% <ø> (ø)
...rdweb/src/extensions/erc721/drops/write/claimTo.ts 79.16% <ø> (ø)

... and 2 files with indirect coverage changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the documentation for the `claimTo` function across the `ERC1155`, `ERC20`, and `ERC721` extensions by adding usage examples for drops with allowlists, emphasizing the need to specify the claimer address.

### Detailed summary
- Added a "### Basic usage" section to the documentation for `claimTo` in all three extensions.
- Introduced a "### For Drops with allowlists" section explaining the need for the `from` parameter.
- Provided code examples for using `claimTo` with allowlists in `ERC1155`, `ERC20`, and `ERC721`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants