Check zksync stack #4869
Merged
Check zksync stack #4869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaryash90
requested review from
MananTank,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
jnsdls
requested changes
Sep 30, 2024
Contributor
size-limit report 📦
|
packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts
Outdated
Show resolved
Hide resolved
jnsdls
requested changes
Oct 1, 2024
jnsdls
approved these changes
Oct 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4869 +/- ##
==========================================
+ Coverage 47.57% 47.59% +0.02%
==========================================
Files 1054 1054
Lines 57109 57136 +27
Branches 3907 3914 +7
==========================================
+ Hits 27167 27195 +28
+ Misses 29254 29253 -1
Partials 688 688
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the `isZkSyncChain` function to be asynchronous and modifying various parts of the codebase to await its result. This change enhances the handling of chain identification, particularly for zkSync-related operations.
### Detailed summary
- Changed `isZkSyncChain` to an async function.
- Updated calls to `isZkSyncChain` to use `await` in several files.
- Modified the logic in `isZkSyncChain` to include additional checks for specific chain IDs.
- Introduced a new async function `getChainStack` for fetching chain stack information.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
yash/zksync-stack-check
branch
from
9e3da67 to
6beec7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating the
isZkSyncChainfunction to be asynchronous and modifying several parts of the codebase to await its result. This change enhances the handling of ZkSync chains during contract deployments and transaction requirements.Detailed summary
isZkSyncChainto anasyncfunction.isZkSyncChainto useawait.getChainStackfunction for fetching chain stack data.