Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 1, 2024

PR-Codex overview

This PR updates the links in the page.mdx file to point to the correct version of the getting started guide for the Unity SDK.

Detailed summary

  • Updated link in the text from /unity/getting-started to /unity/v5/getting-started.
  • Changed href attribute in the <ArticleIconCard> component from /unity/getting-started to /unity/v5/getting-started.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 7:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Oct 1, 2024 7:32pm
thirdweb-www ⬜️ Skipped (Inspect) Oct 1, 2024 7:32pm
wallet-ui ⬜️ Skipped (Inspect) Oct 1, 2024 7:32pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: d3b0dc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0xFirekeeper 0xFirekeeper added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 1, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Merge activity

  • Oct 1, 12:15 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 1, 12:16 PM EDT: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 1, 3:29 PM EDT: 0xFirekeeper added this pull request to the Graphite merge queue.
  • Oct 1, 3:32 PM EDT: 0xFirekeeper merged this pull request with the Graphite merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 1, 2024
@0xFirekeeper 0xFirekeeper added hotfix This pull request should be prioritized in the merge queue. Portal Involves changes to the Portal (docs) codebase. and removed Portal Involves changes to the Portal (docs) codebase. labels Oct 1, 2024
@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.57%. Comparing base (98c5fd0) to head (d3b0dc6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4876   +/-   ##
=======================================
  Coverage   47.57%   47.57%           
=======================================
  Files        1054     1054           
  Lines       57109    57109           
  Branches     3907     3907           
=======================================
  Hits        27167    27167           
  Misses      29254    29254           
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 98c5fd0
packages 43.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.91 KB (0%) 839 ms (0%) 490 ms (+21.23% 🔺) 1.4 s
thirdweb (cjs) 101.54 KB (0%) 2.1 s (0%) 643 ms (-16.09% 🔽) 2.7 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 37 ms (-2.79% 🔽) 133 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 23 ms (+78.85% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 16.76 KB (0%) 336 ms (0%) 93 ms (+19.41% 🔺) 428 ms

<!-- start pr-codex -->

## PR-Codex overview
This PR updates the links in the `page.mdx` file for the Unity SDK to reflect the correct versioning in the URLs.

### Detailed summary
- Updated the link in the text from `/unity/getting-started` to `/unity/v5/getting-started`.
- Changed the `href` attribute of the `ArticleIconCard` component from `/unity/getting-started` to `/unity/v5/getting-started`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@0xFirekeeper 0xFirekeeper force-pushed the firekeeper/fix-get-started-unity-link branch from a972f06 to d3b0dc6 Compare October 1, 2024 19:29
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 1, 2024 19:29 Inactive
@graphite-app graphite-app bot merged commit d3b0dc6 into main Oct 1, 2024
26 checks passed
@graphite-app graphite-app bot deleted the firekeeper/fix-get-started-unity-link branch October 1, 2024 19:32
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 1, 2024 19:32 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 1, 2024 19:32 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 1, 2024 19:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants