Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 1, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the dashboard components to improve organization, enhance accessibility, and update styling. It involves removing unused components, updating imports, and modifying UI elements for better responsiveness and functionality.

Detailed summary

  • Deleted unused files: nav-link.client.tsx, headerLinks.ts, MobileBurgerMenu.tsx.
  • Updated className in several components for styling consistency.
  • Replaced TrackedLinkButton with NavLink in UpgradeButton.
  • Introduced DashboardHeaderTabs to manage header navigation.
  • Modified CreditsButton to use a dialog for credit display.
  • Enhanced CreditsItem to show additional credit information and apply buttons.
  • Updated DashboardHeader to include DashboardHeaderTabs and improved layout.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 7:36pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 1, 2024 7:36pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 1, 2024 7:36pm
wallet-ui ⬜️ Skipped (Inspect) Oct 1, 2024 7:36pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 17:19 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: fd8674a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 17:19 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 1, 2024
@MananTank MananTank marked this pull request as ready for review October 1, 2024 17:19
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.57%. Comparing base (d3b0dc6) to head (fd8674a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4877   +/-   ##
=======================================
  Coverage   47.57%   47.57%           
=======================================
  Files        1054     1054           
  Lines       57109    57109           
  Branches     3907     3907           
=======================================
  Hits        27167    27167           
  Misses      29254    29254           
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d3b0dc6
packages 43.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.91 KB (0%) 839 ms (0%) 3.1 s (-1.87% 🔽) 3.9 s
thirdweb (cjs) 101.54 KB (0%) 2.1 s (0%) 5.7 s (+0.67% 🔺) 7.7 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 244 ms (+105.19% 🔺) 340 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 106 ms (+151.79% 🔺) 116 ms
thirdweb/react (minimal + tree-shaking) 16.76 KB (0%) 336 ms (0%) 1.2 s (+59.88% 🔺) 1.5 s

@MananTank MananTank force-pushed the 10-01-single_header_component_for_app_and_pages_router branch from 52b4e50 to 76f0398 Compare October 1, 2024 17:33
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 17:33 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the dashboard components, enhancing the UI elements, and improving the overall structure of the codebase. It includes updates to navigation, styling, and the introduction of new components for better functionality.

### Detailed summary
- Deleted unused files: `nav-link.client.tsx`, `headerLinks.ts`, `MobileBurgerMenu.tsx`.
- Updated `cmd-k-search` button styling and icon size.
- Changed import paths in `layout.tsx`.
- Added `DashboardHeaderTabs` component to manage navigation.
- Refactored `DashboardHeader` to streamline layout and include new links.
- Updated `ColorModeToggle` and `CreditsButton` for better UI interaction.
- Enhanced `CreditsItem` component layout and functionality.
- Replaced `TrackedLinkButton` with `NavLink` in `UpgradeButton`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-01-single_header_component_for_app_and_pages_router branch from 76f0398 to fd8674a Compare October 1, 2024 19:33
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 19:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 19:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 19:33 Inactive
@graphite-app graphite-app bot merged commit fd8674a into main Oct 1, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-01-single_header_component_for_app_and_pages_router branch October 1, 2024 19:36
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 1, 2024 19:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants