-
Notifications
You must be signed in to change notification settings - Fork 619
Single Header component for App and Pages router #4877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Header component for App and Pages router #4877
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4877 +/- ##
=======================================
Coverage 47.57% 47.57%
=======================================
Files 1054 1054
Lines 57109 57109
Branches 3907 3907
=======================================
Hits 27167 27167
Misses 29254 29254
Partials 688 688
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
52b4e50 to
76f0398
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring the dashboard components, enhancing the UI elements, and improving the overall structure of the codebase. It includes updates to navigation, styling, and the introduction of new components for better functionality.
### Detailed summary
- Deleted unused files: `nav-link.client.tsx`, `headerLinks.ts`, `MobileBurgerMenu.tsx`.
- Updated `cmd-k-search` button styling and icon size.
- Changed import paths in `layout.tsx`.
- Added `DashboardHeaderTabs` component to manage navigation.
- Refactored `DashboardHeader` to streamline layout and include new links.
- Updated `ColorModeToggle` and `CreditsButton` for better UI interaction.
- Enhanced `CreditsItem` component layout and functionality.
- Replaced `TrackedLinkButton` with `NavLink` in `UpgradeButton`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
76f0398 to
fd8674a
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the dashboard components to improve organization, enhance accessibility, and update styling. It involves removing unused components, updating imports, and modifying UI elements for better responsiveness and functionality.
Detailed summary
nav-link.client.tsx,headerLinks.ts,MobileBurgerMenu.tsx.classNamein several components for styling consistency.TrackedLinkButtonwithNavLinkinUpgradeButton.DashboardHeaderTabsto manage header navigation.CreditsButtonto use a dialog for credit display.CreditsItemto show additional credit information and apply buttons.DashboardHeaderto includeDashboardHeaderTabsand improved layout.