Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 1, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the onboarding and billing components in the dashboard application, enhancing the user interface and improving the structure of the code by replacing certain components and updating modal handling.

Detailed summary

  • Replaced OnboardingTitle with TitleAndDescription in multiple components.
  • Updated OnboardingModal to remove unnecessary props and improve structure.
  • Refactored ManageBillingButton to enhance event tracking and button handling.
  • Improved alert components with new UI elements and better handling of alerts.
  • Added new stubs for account and billing data in tests.
  • Updated the BillingAlerts component to manage state and display alerts based on account conditions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 0:17am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 2, 2024 0:17am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 2, 2024 0:17am
wallet-ui ⬜️ Skipped (Inspect) Oct 2, 2024 0:17am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 21:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 21:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 21:37 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: 78cbc41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 1, 2024 21:37
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 1, 2024
Copy link
Member Author

MananTank commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.59%. Comparing base (79c50cb) to head (78cbc41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4879   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files        1054     1054           
  Lines       57144    57144           
  Branches     3914     3914           
=======================================
  Hits        27196    27196           
  Misses      29260    29260           
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 79c50cb
packages 43.33% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.98 KB (0%) 840 ms (0%) 1.4 s (-2.08% 🔽) 2.3 s
thirdweb (cjs) 101.58 KB (0%) 2.1 s (0%) 2.9 s (+0.18% 🔺) 5 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 188 ms (+104.75% 🔺) 284 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 115 ms (+188.54% 🔺) 125 ms
thirdweb/react (minimal + tree-shaking) 16.75 KB (0%) 335 ms (0%) 252 ms (-13.97% 🔽) 587 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily refactors the onboarding and billing components, improving the UI structure and enhancing the modal functionalities. It replaces the `OnboardingTitle` with `TitleAndDescription`, streamlining the code and updating various components for better usability and consistency.

### Detailed summary
- Replaced `<OnboardingTitle>` with `<TitleAndDescription>` in several components.
- Updated `OnboardingModal` to remove redundant `onClose` props.
- Refactored billing alert components to use new UI elements.
- Enhanced the layout of forms and alerts for better UX.
- Improved state management for modal visibility.
- Added new utility functions for account and billing data stubs.
- Updated import statements for consistency and clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-02-migrate_billing_related_components_to_tailwind_shadcn_-_part_1 branch from a28e723 to 78cbc41 Compare October 2, 2024 00:07
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 00:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 00:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 00:07 Inactive
@graphite-app graphite-app bot merged commit 78cbc41 into main Oct 2, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-02-migrate_billing_related_components_to_tailwind_shadcn_-_part_1 branch October 2, 2024 00:17
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 2, 2024 00:17 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 2, 2024 00:17 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 2, 2024 00:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants