-
Notifications
You must be signed in to change notification settings - Fork 619
refactor: optimize zksync chain detection and add Creator Testnet test #4883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimize zksync chain detection and add Creator Testnet test #4883
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 454f063 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
==========================================
+ Coverage 47.59% 47.60% +0.01%
==========================================
Files 1054 1054
Lines 57144 57164 +20
Branches 3914 3917 +3
==========================================
+ Hits 27196 27212 +16
- Misses 29260 29263 +3
- Partials 688 689 +1
*This pull request uses carry forward flags. Click here to find out more.
|
b99cdec to
9817aad
Compare
Merge activity
|
#4883) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring code related to the handling of contract metadata, specifically around bytecode fetching and the integration of `zksync` support. It enhances the clarity and functionality of contract deployment processes. ### Detailed summary - Removed checks for `compilerType` in multiple files. - Simplified bytecode fetching by introducing `fetchBytecodeFromCompilerMetadata`. - Updated contract metadata handling in `fetchDeployMetadata`. - Adjusted UI components to reflect new metadata structure. - Added a test for sending transactions on the Creator Testnet. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
9817aad to
454f063
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the handling of bytecode in the
thirdweblibrary, particularly forzksyncchains, and refactoring related functionalities for better clarity and performance.Detailed summary
publishedMetadatain favor of direct access todescriptionandlogo.fetchBytecodeFromCompilerMetadatafor better bytecode retrieval.SmartWalletto include a new transaction test.isZkSyncChainlogic for clarity.