fix: add missing partner id for ecosystem wallet #4886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 985c4b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4886 +/- ##
==========================================
- Coverage 47.52% 47.49% -0.03%
==========================================
Files 1054 1055 +1
Lines 57152 57191 +39
Branches 3903 3902 -1
==========================================
+ Hits 27159 27165 +6
- Misses 29304 29337 +33
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Oct 2, 2024
joaquim-verges
added
the
merge-queue
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on fixing the issue of missing `partnerId` when creating an ecosystem wallet in the `thirdweb` package.
### Detailed summary
- Updated `partnerId` in `packages/thirdweb/src/wallets/in-app/web/ecosystem.ts` to use `ecosystem.partnerId`.
- Updated `partnerId` in `packages/thirdweb/src/wallets/in-app/native/ecosystem.ts` to use `createOptions?.partnerId`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
winston/fix-ecosystem-missing-partner-id
branch
from
0e0d361 to
985c4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on fixing the issue of missing
partnerIdwhen creating an ecosystem wallet in thethirdwebpackage.Detailed summary
partnerId: ecosystem.partnerIdinpackages/thirdweb/src/wallets/in-app/web/ecosystem.ts.partnerId: createOptions?.partnerIdinpackages/thirdweb/src/wallets/in-app/native/ecosystem.ts.