api server url env cleanup #4887

MananTank · 2024-10-02T15:29:18Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on refactoring the API server URL usage across multiple files in the dashboard application. It introduces a new constant, API_SERVER_URL, to centralize the management of the API endpoint, replacing direct references to the environment variable.

Detailed summary

Added API_SERVER_URL constant in env.ts.
Replaced direct environment variable references with API_SERVER_URL in:
- getAccount.ts
- fetchEcosystemList.ts
- fetchEcosystem.ts
- team-members.ts
- get-auth-token/route.ts
- getAPIKeys.ts
- ensure-login/route.ts
- server-proxy/api/[...paths].tsx
- team.ts
- projects.ts
- create-ticket.action.ts
- auth-actions.ts
- utils.ts
Updated fetch requests to use API_SERVER_URL for consistency and maintainability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-02T15:29:22Z

⚠️ No Changeset found

Latest commit: 025c581

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2024-10-02T15:29:34Z

WIP - Plug in Project Settings Page UI with API #4924
Plug in Team settings page UI to API #4888
api server url env cleanup #4887 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

vercel · 2024-10-02T15:29:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 5:42pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 2, 2024 5:42pm
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 2, 2024 5:42pm
wallet-ui	⬜️ Skipped (Inspect)	Oct 2, 2024 5:42pm

codecov · 2024-10-02T15:31:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (522968a) to head (025c581).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4887   +/-   ##
=======================================
  Coverage   47.60%   47.60%           
=======================================
  Files        1054     1054           
  Lines       57164    57164           
  Branches     3917     3917           
=======================================
  Hits        27212    27212           
  Misses      29263    29263           
  Partials      689      689

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 522968a
packages	`43.35% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-10-02T15:32:53Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.98 KB (0%)	840 ms (0%)	561 ms (+81.32% 🔺)	1.4 s
thirdweb (cjs)	101.58 KB (0%)	2.1 s (0%)	936 ms (+0.07% 🔺)	3 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	96 ms (+273.65% 🔺)	192 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	22 ms (+119.82% 🔺)	32 ms
thirdweb/react (minimal + tree-shaking)	16.75 KB (0%)	335 ms (0%)	111 ms (-22.19% 🔽)	446 ms

graphite-app · 2024-10-02T15:34:29Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

jnsdls · 2024-10-02T17:36:25Z

apps/dashboard/src/@/constants/env.ts

  process.env.NEXT_PUBLIC_DASHBOARD_UPLOAD_SERVER ||
  "https://storage.thirdweb.com";
+
+export const API_SERVER_URL =


as long as we're clear that this is only supposed to be used in backend functions and never directly from the client this is fine.

graphite-app · 2024-10-02T17:38:28Z

Merge activity

Oct 2, 1:38 PM EDT: MananTank added this pull request to the Graphite merge queue.
Oct 2, 1:42 PM EDT: MananTank merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR introduces a new constant, `API_SERVER_URL`, to centralize the API server URL configuration. It replaces instances of `process.env.NEXT_PUBLIC_THIRDWEB_API_HOST` throughout the codebase, enhancing maintainability and readability. ### Detailed summary - Added `API_SERVER_URL` in `env.ts`. - Replaced `process.env.NEXT_PUBLIC_THIRDWEB_API_HOST` with `API_SERVER_URL` in multiple files: - `getAccount.ts` - `fetchEcosystemList.ts` - `fetchEcosystem.ts` - `team-members.ts` - `get-auth-token/route.ts` - `getAPIKeys.ts` - `ensure-login/route.ts` - `server-proxy/api/[...paths].tsx` - `team.ts` - `projects.ts` - `create-ticket.action.ts` - `auth-actions.ts` - `utils.ts` - Updated fetch requests to use `API_SERVER_URL` for consistent API endpoint access. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 2, 2024

vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 15:29 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 15:29 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 15:29 Inactive

MananTank marked this pull request as ready for review October 2, 2024 15:30

MananTank requested review from jnsdls and joaquim-verges as code owners October 2, 2024 15:30

vercel bot deployed to Preview – thirdweb-www October 2, 2024 15:39 View deployment

MananTank mentioned this pull request Oct 2, 2024

Plug in Team settings page UI to API #4888

Merged

jnsdls approved these changes Oct 2, 2024

View reviewed changes

MananTank force-pushed the 10-02-api_server_url_env_cleanup branch from a58d9ae to 025c581 Compare October 2, 2024 17:39

vercel bot deployed to Preview – docs-v2 October 2, 2024 17:39 View deployment

vercel bot deployed to Preview – thirdweb_playground October 2, 2024 17:39 View deployment

vercel bot deployed to Preview – wallet-ui October 2, 2024 17:39 View deployment

vercel bot deployed to Preview – thirdweb-www October 2, 2024 17:42 View deployment

graphite-app bot merged commit 025c581 into main Oct 2, 2024
26 checks passed

graphite-app bot deleted the 10-02-api_server_url_env_cleanup branch October 2, 2024 17:42

vercel bot temporarily deployed to Production – docs-v2 October 2, 2024 17:42 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground October 2, 2024 17:42 Inactive

vercel bot temporarily deployed to Production – wallet-ui October 2, 2024 17:42 Inactive

vercel bot deployed to Production – thirdweb-www October 2, 2024 17:52 View deployment

MananTank mentioned this pull request Oct 4, 2024

WIP - Plug in Project Settings Page UI with API #4924

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

api server url env cleanup #4887

api server url env cleanup #4887

MananTank commented Oct 2, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

MananTank commented Oct 2, 2024 •

edited

Loading

Uh oh!

vercel bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 2, 2024

Uh oh!

jnsdls Oct 2, 2024

Uh oh!

graphite-app bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

api server url env cleanup #4887

api server url env cleanup #4887

Conversation

MananTank commented Oct 2, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

jnsdls Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 2, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 2, 2024 •

edited

Loading

MananTank commented Oct 2, 2024 •

edited

Loading

vercel bot commented Oct 2, 2024 •

edited

Loading

codecov bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

graphite-app bot commented Oct 2, 2024 •

edited

Loading