Plug in Team settings page UI to API #4888
Merged
+107
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MananTank
changed the title
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4888 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57224 57224
Branches 3924 3924
=======================================
Hits 27247 27247
Misses 29288 29288
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
MananTank
changed the base branch from
10-02-api_server_url_env_cleanup
to
graphite-base/4888
MananTank
force-pushed
the
10-02-plug_in_team_settings_page_ui_to_api
branch
from
fa207ad to
82f54ef
Compare
MananTank
force-pushed
the
10-02-plug_in_team_settings_page_ui_to_api
branch
from
82f54ef to
83e7e6f
Compare
MananTank
force-pushed
the
10-02-plug_in_team_settings_page_ui_to_api
branch
from
83e7e6f to
285ba5d
Compare
MananTank
force-pushed
the
10-02-plug_in_team_settings_page_ui_to_api
branch
from
285ba5d to
536baf8
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/app/team/[team_slug]/(team)/~/settings/general/TeamGeneralSettingsPageUI.tsx
Outdated
Show resolved
Hide resolved
MananTank
force-pushed
the
10-02-plug_in_team_settings_page_ui_to_api
branch
from
536baf8 to
a90df36
Compare
apps/dashboard/src/app/team/[team_slug]/(team)/~/settings/general/TeamGeneralSettingsPageUI.tsx
Show resolved
Hide resolved
MananTank
changed the title
jnsdls
approved these changes
Oct 4, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on enhancing the `Team` functionality by adding billing features, updating team settings, and refining the UI components to support new properties such as `billingEmail` and `image`. It also improves the update mechanisms for team attributes.
### Detailed summary
- Added `billingEmail` and `image` fields to the `Team` model.
- Updated the `TeamGeneralSettingsPage` to accept `authToken` instead of `client`.
- Implemented `updateTeam` function to handle team updates.
- Modified UI components to support new fields and update methods.
- Enhanced `FileInput` to handle fallback URLs.
- Refactored `TeamNameFormControl` and `TeamSlugFormControl` to utilize `updateTeamField` for updates.
- Integrated `resolveScheme` for avatar URL handling in `TeamAvatarFormControl`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
10-02-plug_in_team_settings_page_ui_to_api
branch
from
a90df36 to
b148fa0
Compare
graphite-app
bot
deleted the
10-02-plug_in_team_settings_page_ui_to_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
Teamobject structure and its related components, primarily by adding new properties and improving the update functionality for team settings.Detailed summary
billingEmailtoTeamobject.deletedAtandbannedAtoptional.updateTeamfunction for updating team details.TeamGeneralSettingsPageto useauthTokeninstead ofclient.TeamGeneralSettingsPageUIfor updating team fields and images.updateTeamFieldprop toTeamNameFormControlandTeamSlugFormControl.FileInputcomponent.TeamAvatarFormControlto use the resolved image URL.