Skip to content

Spacing fixes on OnboardingGeneral component #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Spacing fixes on OnboardingGeneral component #4891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions apps/dashboard/src/components/onboarding/General.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { Account } from "@3rdweb-sdk/react/hooks/useApi";
import { Flex, FocusLock } from "@chakra-ui/react";
import { AccountForm } from "components/settings/Account/AccountForm";
import { useState } from "react";
import { useActiveWallet, useDisconnect } from "thirdweb/react";
Expand Down Expand Up @@ -33,7 +32,7 @@ const OnboardingGeneral: React.FC<OnboardingGeneralProps> = ({
}

return (
<FocusLock>
<div>
<TitleAndDescription
heading={
!existing
Expand All @@ -43,7 +42,9 @@ const OnboardingGeneral: React.FC<OnboardingGeneralProps> = ({
description="Start building web3 apps and games, faster."
/>

<Flex flexDir="column" gap={4}>
<div className="h-6" />

<div className="flex flex-col gap-4">
<AccountForm
showSubscription={!existing}
hideName={existing}
Expand Down Expand Up @@ -95,8 +96,8 @@ const OnboardingGeneral: React.FC<OnboardingGeneralProps> = ({
</Button>
)}
</div>
</Flex>
</FocusLock>
</div>
</div>
);
};

Expand Down
13 changes: 6 additions & 7 deletions apps/dashboard/src/components/settings/Account/AccountForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Input } from "@/components/ui/input";
import { cn } from "@/lib/utils";
import { type Account, useUpdateAccount } from "@3rdweb-sdk/react/hooks/useApi";
import { Flex, FormControl, Input } from "@chakra-ui/react";
import { Flex, FormControl } from "@chakra-ui/react";
import { zodResolver } from "@hookform/resolvers/zod";
import { ManageBillingButton } from "components/settings/Account/Billing/ManageButton";
import { useTrack } from "hooks/analytics/useTrack";
Expand Down Expand Up @@ -132,15 +133,13 @@ export const AccountForm: React.FC<AccountFormProps> = ({
<form onSubmit={handleSubmit}>
<div
className={cn(
"w-full items-start rounded-xl bg-background",
"flex w-full flex-col items-start rounded-xl bg-background",
horizontal ? "gap-6" : "gap-8",
padded ? "border border-border p-6" : "p-0",
)}
>
<Flex
gap={horizontal ? 4 : 8}
flexDir={horizontal ? "row" : "column"}
w="full"
<div
className={cn("flex w-full", horizontal ? "gap-4" : "flex-col gap-6")}
>
<FormControl
isRequired
Expand Down Expand Up @@ -217,7 +216,7 @@ export const AccountForm: React.FC<AccountFormProps> = ({
<Text>Subscribe to new features and key product updates</Text>
</Checkbox>
)}
</Flex>
</div>

<div
className={cn(
Expand Down
Loading