Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 2, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the SettingsBillingPage component to accept a teamId prop, allowing for team-specific billing functionality. It also introduces a CouponCard component for applying discount coupons, improving the billing experience.

Detailed summary

  • Updated SettingsBillingPage to accept teamId.
  • Modified Page to pass teamId from the team slug.
  • Enhanced Billing component to use teamId.
  • Created CouponCard for applying discount coupons.
  • Added form handling and validation for coupon submissions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 9:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 2, 2024 9:58pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 2, 2024 9:58pm
wallet-ui ⬜️ Skipped (Inspect) Oct 2, 2024 9:58pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 20:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 20:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 20:19 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: 9fb5401

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review October 2, 2024 20:19
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 2, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.52%. Comparing base (e548675) to head (9fb5401).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4895   +/-   ##
=======================================
  Coverage   47.52%   47.52%           
=======================================
  Files        1054     1054           
  Lines       57152    57152           
  Branches     3903     3903           
=======================================
  Hits        27159    27159           
  Misses      29304    29304           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e548675
packages 43.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 352 ms (+67.19% 🔺) 1.2 s
thirdweb (cjs) 101.7 KB (0%) 2.1 s (0%) 682 ms (-18.74% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 53 ms (-23.32% 🔽) 150 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 17 ms (+168.19% 🔺) 27 ms
thirdweb/react (minimal + tree-shaking) 16.74 KB (0%) 335 ms (0%) 65 ms (-58.53% 🔽) 400 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `SettingsBillingPage` component by adding a `teamId` prop to manage billing settings for different teams. It also introduces a new `CouponCard` component that allows users to apply coupon codes with relevant feedback.

### Detailed summary
- Updated `Page` component to pass `teamId` to `SettingsBillingPage`.
- Modified `SettingsBillingPage` to accept `teamId` as a prop.
- Adjusted `Billing` component to use `teamId` in its rendering.
- Introduced `CouponCard` component for applying coupon codes.
- Implemented logic in `CouponCard` to handle coupon submissions and display feedback based on response status.
- Updated `Billing` component to include `CouponCard`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-03-add_coupon_card_in_billing_page branch from d9ae32b to 9fb5401 Compare October 2, 2024 21:48
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 21:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 21:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 21:48 Inactive
@graphite-app graphite-app bot merged commit 9fb5401 into main Oct 2, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-03-add_coupon_card_in_billing_page branch October 2, 2024 21:58
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 2, 2024 21:58 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 2, 2024 21:58 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 2, 2024 21:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants