Skip to content

Conversation

@ElasticBottle
Copy link
Contributor

@ElasticBottle ElasticBottle commented Oct 2, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the information regarding compliance with GDPR and CCPA in the page.mdx file, providing more detailed and accurate descriptions of the standards and the timeframe for data deletion.

Detailed summary

  • Modified the compliance statement for GDPR and CCPA.
  • Changed the text from "In-app wallets are compliant with GDPR and CCPA within 90 days" to a more detailed explanation of thirdweb's compliance and data deletion timelines (30 days for GDPR and 45 for CCPA).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: 367a270

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 1:12am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Oct 3, 2024 1:12am
thirdweb-www ⬜️ Skipped (Inspect) Oct 3, 2024 1:12am
wallet-ui ⬜️ Skipped (Inspect) Oct 3, 2024 1:12am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 2, 2024
@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.57%. Comparing base (e91581a) to head (367a270).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4897   +/-   ##
=======================================
  Coverage   47.57%   47.57%           
=======================================
  Files        1054     1054           
  Lines       57142    57142           
  Branches     3918     3918           
=======================================
  Hits        27185    27185           
  Misses      29268    29268           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e91581a
packages 43.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 4.3 s (+56.68% 🔺) 5.1 s
thirdweb (cjs) 101.63 KB (0%) 2.1 s (0%) 8.5 s (+34.86% 🔺) 10.5 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 1.7 s (+924.16% 🔺) 1.8 s
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 144 ms (+199.59% 🔺) 154 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 1.3 s (+98.41% 🔺) 1.6 s

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 2, 2024 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 22:48 Inactive
@ElasticBottle ElasticBottle added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 2, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Merge activity

  • Oct 2, 6:48 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 2, 9:02 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 2, 9:02 PM EDT: joaquim-verges added this pull request to the Graphite merge queue.
  • Oct 2, 9:05 PM EDT: joaquim-verges merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the compliance information regarding GDPR and CCPA in the `page.mdx` file, providing more detailed and accurate descriptions of the data handling practices.

### Detailed summary
- Updated the compliance statement for GDPR and CCPA.
- Changed the text from a general statement about in-app wallets to specify that `thirdweb` complies with GDPR and CCPA frameworks.
- Clarified the timeframe for data deletion requests (30 days for GDPR and 45 for CCPA).

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 01:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 3, 2024 01:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 01:03 Inactive
@graphite-app graphite-app bot merged commit 367a270 into main Oct 3, 2024
26 checks passed
@graphite-app graphite-app bot deleted the winston/update-docs branch October 3, 2024 01:05
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 3, 2024 01:05 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 3, 2024 01:05 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 3, 2024 01:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants