Skip to content

feat: optimize zksync contract deployment and bytecode handling #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

feat: optimize zksync contract deployment and bytecode handling #4902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e66d7a
feat: optimize zksync contract deployment and bytecode handling
joaquim-verges Oct 3, 2024
119ebf1
disable test for now
joaquim-verges Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,11 @@
client: ThirdwebClient;
}) {
const { chain, client } = args;
const isZkSync = await isZkSyncChain(chain);
if (isZkSync) {
// zksync contracts dont need these implementation constructor params
return {};
}

Check warning on line 217 in packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts#L216-L217 

Added lines #L216 - L217 were not covered by tests
const [forwarder, weth] = await Promise.all([
computePublishedContractAddress({
chain,
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/utils/any-evm/deploy-metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
async () => {
const isZksolc = await isZkSyncChain(chain);
const bytecodeUri = isZksolc
? compilerMetadata.compilers?.zksolc[0]?.bytecodeUri
? compilerMetadata.compilers?.zksolc?.[0]?.bytecodeUri

Check warning on line 83 in packages/thirdweb/src/utils/any-evm/deploy-metadata.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/utils/any-evm/deploy-metadata.ts#L83 

Added line #L83 was not covered by tests
: compilerMetadata.bytecodeUri;

if (!bytecodeUri) {
Expand Down