[SDK] Unstoppable Domains resolvers #4905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kien-ngo
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: a453d96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4905 +/- ##
==========================================
+ Coverage 47.57% 47.61% +0.04%
==========================================
Files 1054 1057 +3
Lines 57146 57221 +75
Branches 3918 3924 +6
==========================================
+ Hits 27186 27246 +60
- Misses 29271 29286 +15
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Oct 3, 2024
Member
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
cool stuff @kien-ngo !!
Contributor
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on adding support for Unstoppable Domains within the `thirdweb` SDK, including new resolvers for names and addresses, and enhancing functionality through tests and constants.
### Detailed summary
- Added `UD_POLYGON_MAINNET` constant.
- Introduced functions: `resolveName`, `resolveAddress`, `reverseNameOf`, `getMany`, and `namehash`.
- Implemented tests for `resolveName` and `resolveAddress`.
- Added exports for new types and functions in `unstoppable-domains.ts`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/unstoppable-domains
branch
from
bf7e209 to
a453d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR adds support for resolving names and addresses using Unstoppable Domains in the
thirdwebSDK. It introduces new functions for name resolution and address retrieval, along with necessary constants and tests.Detailed summary
UD_POLYGON_MAINNETconstant.reverseNameOf,getMany,namehashfunctions for name/address resolution.resolveNameandresolveAddressfunctions with options for custom resolvers.resolveNameandresolveAddress.unstoppable-domains.