Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 3, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the SheetContent component's styling by adding an overflow-y-auto class, which allows for vertical scrolling when the content exceeds the available space.

Detailed summary

  • Modified the SheetContent component in airdrop-button.tsx to include the overflow-y-auto class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: 422a725

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 2:42pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 3, 2024 2:42pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 3, 2024 2:42pm
wallet-ui ⬜️ Skipped (Inspect) Oct 3, 2024 2:42pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 3, 2024
@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (d1d3fdc) to head (422a725).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4909   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57221    57221           
  Branches     3924     3924           
=======================================
  Hits        27246    27246           
  Misses      29286    29286           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d1d3fdc
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 459 ms (+13.11% 🔺) 1.3 s
thirdweb (cjs) 101.63 KB (0%) 2.1 s (0%) 852 ms (+16.12% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 70 ms (+129.58% 🔺) 166 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 68 ms (+240.95% 🔺) 78 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 107 ms (+63.03% 🔺) 452 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on modifying the `className` of the `SheetContent` component in the `airdrop-button.tsx` file to improve its styling by adding an `overflow-y-auto` class, allowing for vertical scrolling if the content exceeds the available space.

### Detailed summary
- Updated the `className` of the `SheetContent` component:
  - Added `overflow-y-auto` to enable vertical scrolling.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/fix-erc20-airdrop branch from b264b15 to 422a725 Compare October 3, 2024 14:39
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 14:39 Inactive
@graphite-app graphite-app bot merged commit 422a725 into main Oct 3, 2024
26 checks passed
@graphite-app graphite-app bot deleted the kien/fix-erc20-airdrop branch October 3, 2024 14:43
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 3, 2024 14:43 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 3, 2024 14:43 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 3, 2024 14:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants