[Dashboard] Fix airdrop erc20 scroll issue #4909

kien-ngo · 2024-10-03T14:28:19Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the SheetContent component's styling by adding an overflow-y-auto class, which allows for vertical scrolling when the content exceeds the available space.

Detailed summary

Modified the SheetContent component in airdrop-button.tsx to include the overflow-y-auto class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-03T14:28:24Z

⚠️ No Changeset found

Latest commit: 422a725

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-10-03T14:28:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 3, 2024 2:42pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 3, 2024 2:42pm
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 3, 2024 2:42pm
wallet-ui	⬜️ Skipped (Inspect)	Oct 3, 2024 2:42pm

graphite-app · 2024-10-03T14:28:28Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codecov · 2024-10-03T14:30:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (d1d3fdc) to head (422a725).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4909   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57221    57221           
  Branches     3924     3924           
=======================================
  Hits        27246    27246           
  Misses      29286    29286           
  Partials      689      689

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from d1d3fdc
packages	`43.37% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-10-03T14:31:43Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.95 KB (0%)	840 ms (0%)	459 ms (+13.11% 🔺)	1.3 s
thirdweb (cjs)	101.63 KB (0%)	2.1 s (0%)	852 ms (+16.12% 🔺)	2.9 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	70 ms (+129.58% 🔺)	166 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	68 ms (+240.95% 🔺)	78 ms
thirdweb/react (minimal + tree-shaking)	17.23 KB (0%)	345 ms (0%)	107 ms (+63.03% 🔺)	452 ms

graphite-app · 2024-10-03T14:38:27Z

Merge activity

Oct 3, 10:38 AM EDT: MananTank added this pull request to the Graphite merge queue.
Oct 3, 10:43 AM EDT: MananTank merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on modifying the `className` of the `SheetContent` component in the `airdrop-button.tsx` file to improve its styling by adding an `overflow-y-auto` class, allowing for vertical scrolling if the content exceeds the available space. ### Detailed summary - Updated the `className` of the `SheetContent` component: - Added `overflow-y-auto` to enable vertical scrolling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kien-ngo self-assigned this Oct 3, 2024

kien-ngo requested review from MananTank, jnsdls and joaquim-verges as code owners October 3, 2024 14:28

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 3, 2024

MananTank approved these changes Oct 3, 2024

View reviewed changes

vercel bot deployed to Preview – thirdweb-www October 3, 2024 14:38 View deployment

MananTank force-pushed the kien/fix-erc20-airdrop branch from b264b15 to 422a725 Compare October 3, 2024 14:39

vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 14:39 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 14:39 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 14:39 Inactive

vercel bot deployed to Preview – thirdweb-www October 3, 2024 14:42 View deployment

graphite-app bot merged commit 422a725 into main Oct 3, 2024
26 checks passed

graphite-app bot deleted the kien/fix-erc20-airdrop branch October 3, 2024 14:43

vercel bot temporarily deployed to Production – thirdweb_playground October 3, 2024 14:43 Inactive

vercel bot temporarily deployed to Production – docs-v2 October 3, 2024 14:43 Inactive

vercel bot temporarily deployed to Production – wallet-ui October 3, 2024 14:43 Inactive

vercel bot deployed to Production – thirdweb-www October 3, 2024 14:53 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dashboard] Fix airdrop erc20 scroll issue #4909

[Dashboard] Fix airdrop erc20 scroll issue #4909

Uh oh!

kien-ngo commented Oct 3, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 3, 2024 •

edited

Loading

Uh oh!

vercel bot commented Oct 3, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 3, 2024

Uh oh!

codecov bot commented Oct 3, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 3, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 3, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Dashboard] Fix airdrop erc20 scroll issue #4909

[Dashboard] Fix airdrop erc20 scroll issue #4909

Uh oh!

Conversation

kien-ngo commented Oct 3, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Oct 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

codecov bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Oct 3, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 3, 2024 •

edited

Loading

vercel bot commented Oct 3, 2024 •

edited

Loading

codecov bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

graphite-app bot commented Oct 3, 2024 •

edited

Loading