fix: handle 0n as from/to blocks in getContractEvents #4919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d4c423c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
Contributor
size-limit report 📦
|
gregfromstl
approved these changes
Oct 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4919 +/- ##
=======================================
Coverage 47.60% 47.60%
=======================================
Files 1057 1057
Lines 57228 57228
Branches 3923 3924 +1
=======================================
+ Hits 27241 27245 +4
+ Misses 29298 29294 -4
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
Merge activity
|
Fixes CNCT-1987 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the validation of `fromBlock` and `toBlock` parameters in the `getContractEvents` function to ensure they are explicitly defined before performing any calculations. ### Detailed summary - Updated condition to check if `fromBlock` and `toBlock` are not `undefined` instead of truthy. - Adjusted logic for setting `restParams.toBlock` and `restParams.fromBlock` based on the new checks. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
joaquim-verges
force-pushed
the
fix_handle_0n_as_from/to_blocks_in_getContractEvents
branch
from
27914b9 to
d4c423c
Compare
graphite-app
bot
deleted the
fix_handle_0n_as_from/to_blocks_in_getContractEvents
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CNCT-1987
PR-Codex overview
This PR focuses on improving the validation of
fromBlockandtoBlockinputs in thegetContractEventsfunction to ensure they are properly defined. It fixes the handling of cases where these values might be0n.Detailed summary
fromBlockandtoBlockto ensure they are notundefined.restParams.toBlockandrestParams.fromBlockto account for inclusive ranges.