Skip to content

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Oct 4, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces caching functionality to the computeCreate2FactoryAddress function in the create-2-factory.ts file, improving efficiency by reducing redundant computations for the same input parameters.

Detailed summary

  • Added import for withCache.
  • Wrapped the main logic of computeCreate2FactoryAddress in withCache.
  • Introduced caching with a cacheKey and cacheTime of 1 day.
  • Adjusted indentation for better readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:35pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:35pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:35pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:35pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: ac5af1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.96 KB (0%) 840 ms (0%) 766 ms (+44.44% 🔺) 1.7 s
thirdweb (cjs) 101.68 KB (0%) 2.1 s (0%) 1.2 s (-7.17% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 99 ms (+94.94% 🔺) 195 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 47 ms (-1.28% 🔽) 57 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 163 ms (-17.56% 🔽) 508 ms

@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 52.30769% with 31 lines in your changes missing coverage. Please review.

Project coverage is 47.61%. Comparing base (c935fbf) to head (ac5af1b).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../src/contract/deployment/utils/create-2-factory.ts 52.30% 31 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4922   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57224    57237   +13     
  Branches     3924     3926    +2     
=======================================
+ Hits        27247    27256    +9     
- Misses      29288    29292    +4     
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c935fbf
packages 43.37% <52.30%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../src/contract/deployment/utils/create-2-factory.ts 68.24% <52.30%> (+0.51%) ⬆️

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 5211446 into main Oct 4, 2024
27 checks passed
@joaquim-verges joaquim-verges deleted the yash/cache-create2factory branch October 4, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants