Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 4, 2024

Current:

image.png

Fixed:

image.png


PR-Codex overview

This PR focuses on improving the layout and styling of the GetStartedWithContractsDeploy component by adjusting button width and modifying the heading alignment.

Detailed summary

  • Changed the className of the <button> to set its width to full (w-full).
  • Modified the <h4> tag's className to align text to the start (text-start), enhancing readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 3:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 4, 2024 3:39pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 4, 2024 3:39pm
wallet-ui ⬜️ Skipped (Inspect) Oct 4, 2024 3:39pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 14:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 14:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 14:27 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 04f8269

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 4, 2024
@MananTank MananTank marked this pull request as ready for review October 4, 2024 14:28
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (c935fbf) to head (04f8269).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4923   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57224    57224           
  Branches     3924     3924           
=======================================
  Hits        27247    27247           
  Misses      29288    29288           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c935fbf
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.96 KB (0%) 840 ms (0%) 398 ms (+1.17% 🔺) 1.3 s
thirdweb (cjs) 101.68 KB (0%) 2.1 s (0%) 776 ms (-14.68% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 75 ms (+13.49% 🔺) 172 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 55 ms (+190.82% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 214 ms (+46.44% 🔺) 558 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2024

Merge activity

@MananTank MananTank force-pushed the 10-04-fix_get_started_with_deploying_contracts_card_buttons_layout branch from e8b418e to 04f8269 Compare October 4, 2024 15:36
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 15:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 15:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 15:36 Inactive
@graphite-app graphite-app bot merged commit 04f8269 into main Oct 4, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-04-fix_get_started_with_deploying_contracts_card_buttons_layout branch October 4, 2024 15:39
@vercel vercel bot temporarily deployed to Production – docs-v2 October 4, 2024 15:39 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 4, 2024 15:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 4, 2024 15:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants