-
Notifications
You must be signed in to change notification settings - Fork 620
Remove calls to 0.rpc on deploy page #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4925 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57224 57224
Branches 3924 3924
=======================================
Hits 27247 27247
Misses 29288 29288
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Merge activity
|
6175d6f to
5c8766b
Compare

Fixes: DASH-268
PR-Codex overview
This PR focuses on improving the handling of the
chainIdparameter in theuseCustomFactoryAbifunction to allow it to beundefined. It enhances error handling when the contract is not found, ensuring better robustness in the code.Detailed summary
useCustomFactoryAbito acceptchainIdasnumber | undefined.chainto returnundefinedif not available.queryFnto throw an error if thecontractis not found.