Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 7, 2024

Problem solved

Adds new screen to show all wallet connect wallets + search bar in RN

image.png

image.png

image.png

Fixes CNCT-1686


PR-Codex overview

This PR introduces multiple updates and improvements to wallet integrations in the thirdweb project, enhancing mobile and desktop wallet support, updating wallet details, and refining error handling in the connection process.

Detailed summary

  • Added support for "show all wallets" option in React Native Connect UI.
  • Updated universal links for swopme and plena wallets.
  • Renamed wallets like GateWeb3 to GateWallet and Bonuz - Social ID to Bonuz Social Smart Wallet.
  • Modified error handling in sessionHandler to provide better feedback on URI opening failures.
  • Enhanced ThemedInput component to include leftView prop.
  • Updated various wallet configurations, including homepage and image_id.
  • Added new wallets: Nicegram Wallet, Open Wallet, and Status.
  • Removed deprecated wallets and images from the generated files.

The following files were skipped due to too many changes: packages/thirdweb/src/wallets/__generated__/wallet/pro.fintoken/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/tech.defiantapp/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/so.onekey.app.wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.trusteeglobal/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/ai.hacken/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.shido/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.plasma-wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.ullapay/image.ts, packages/thirdweb/src/react/native/ui/connect/ExternalWalletsList.tsx, packages/thirdweb/src/wallets/__generated__/wallet/com.brave.wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/me.astrox/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.cardstack/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.enjin/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/network.mrhb/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.lif3/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/app.sinum/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.paybolt/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.kriptomat/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.wallacy/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bitpie/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.rktechworks/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/zone.bitverse/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/xyz.nestwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.tokoin/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/app.imem/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.kresus/image.ts, packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bmawallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/co.cyber.wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.coin98/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.wemix/image.ts, packages/thirdweb/src/wallets/__generated__/wallet-infos.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: f0d4f0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:17am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:17am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:17am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:17am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@linear
Copy link

linear bot commented Oct 7, 2024

@joaquim-verges joaquim-verges marked this pull request as ready for review October 7, 2024 07:57
@codecov
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.61%. Comparing base (11de1f3) to head (f0d4f0c).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../thirdweb/src/wallets/wallet-connect/controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4933   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57241    57241           
  Branches     3925     3926    +1     
=======================================
+ Hits        27256    27257    +1     
+ Misses      29296    29295    -1     
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2f9acb8
packages 43.37% <0.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../thirdweb/src/wallets/wallet-connect/controller.ts 9.44% <0.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.1 KB (0%) 842 ms (0%) 799 ms (-3.71% 🔽) 1.7 s
thirdweb (cjs) 101.73 KB (0%) 2.1 s (0%) 1.7 s (+0.02% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 61 ms (-49.76% 🔽) 157 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 36 ms (+77.25% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 167 ms (-20.97% 🔽) 511 ms

@joaquim-verges joaquim-verges merged commit 506764d into main Oct 7, 2024
26 of 27 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/rn-all-wallets branch October 7, 2024 22:19
@jnsdls jnsdls mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants