chore: don't override auth token / client id when hitting in app wall… #4974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 6a4b776 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
added
the
merge-queue
Contributor
Merge activity
|
gregfromstl
approved these changes
Oct 9, 2024
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4974 +/- ##
=======================================
Coverage 47.66% 47.67%
=======================================
Files 1057 1057
Lines 57267 57277 +10
Branches 3939 3940 +1
=======================================
+ Hits 27299 27307 +8
- Misses 29277 29279 +2
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
#4974) …et url ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `thirdweb` dashboard by allowing account linking and improving the authorization logic in the `fetch.ts` file. ### Detailed summary - Updated the authorization check in `fetch.ts` to exclude URLs from in-app wallets when sending the `authToken`. - Introduced a new function `isInAppWalletUrl(url: string): boolean` to determine if a URL is from an in-app or embedded wallet. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
winston/fix-allow-client-linking-on-thirdweb-dashboard
branch
from
a7c31de to
6a4b776
Compare
graphite-app
bot
deleted the
winston/fix-allow-client-linking-on-thirdweb-dashboard
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…et url
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the authentication logic in the
thirdwebdashboard by allowing account linking and preventing the use of auth tokens in specific URLs.Detailed summary
authTokeninfetch.tsto include a check forisInAppWalletUrl.isInAppWalletUrlto identify URLs related to in-app wallets based on their hostname.