[React Native SDK] Fix: Remove device share if recovering private key fails

[gregfromstl]

PR-Codex overview

This PR introduces error handling improvements and a new function for managing device shares in the wallet system. It enhances user feedback for invalid device shares and ensures proper cleanup of device share data when errors occur.

Detailed summary

• Added INVALID_DEVICE_SHARE_MESSAGE constant to provide a specific error message for invalid device shares.
• Implemented removeDeviceShare function to remove device shares based on clientId.
• Updated error handling in getWalletPrivateKeyFromShares to use the new error message.
• Modified getAccountFromShares to call removeDeviceShare when an invalid device state is detected.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

⚠️ No Changeset found

Latest commit: abbe430

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 10:46pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 10:46pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 10:46pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 10:46pm

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.07 KB (0%)	842 ms (0%)	427 ms (+33.32% 🔺)	1.3 s
thirdweb (cjs)	101.66 KB (0%)	2.1 s (0%)	842 ms (+3.18% 🔺)	2.9 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	24 ms (+8.34% 🔺)	121 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	7 ms (-67.22% 🔽)	17 ms
thirdweb/react (minimal + tree-shaking)	17.24 KB (0%)	345 ms (0%)	106 ms (+46.05% 🔺)	451 ms

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.68%. Comparing base (6a4b776) to head (abbe430).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4976      +/-   ##
==========================================
+ Coverage   47.67%   47.68%   +0.01%     
==========================================
  Files        1057     1058       +1     
  Lines       57277    57290      +13     
  Branches     3940     3943       +3     
==========================================
+ Hits        27307    27320      +13     
  Misses      29279    29279              
  Partials      691      691              

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.68% <ø> (ø)		Carriedforward from 6a4b776
packages	43.46% <ø> (+0.01%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

[joaquim-verges]

lil changeset for this?

[ElasticBottle]

Merge activity

• Oct 9, 10:27 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.