Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new blockchain chain definition for soneiumMinato and modifies the wallet linking functionality in the App component to support linking to Metamask and Passkey instead of Coinbase Wallet.

Detailed summary

  • Added soneiumMinato chain definition in packages/thirdweb/src/chains/chain-definitions/soneium-minato.ts.
  • Exported soneiumMinato in packages/thirdweb/src/exports/chains.ts.
  • Updated the App component in apps/playground-web/src/components/in-app-wallet/profile-sections.tsx to:
    • Implement linkMetamask function for linking to Metamask.
    • Implement linkPasskey function for linking to Passkey.
    • Replace the Link Coinbase Wallet button with buttons for Link Metamask and Link Passkey.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 7c10343

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 9:59pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 9:59pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 9:59pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 9:59pm

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 1.1 s (+10.73% 🔺) 1.9 s
thirdweb (cjs) 101.66 KB (0%) 2.1 s (0%) 1.6 s (-3.97% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 50 ms (-32.01% 🔽) 147 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 161 ms (+523.13% 🔺) 171 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 177 ms (+6.57% 🔺) 522 ms

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.68%. Comparing base (6a4b776) to head (7c10343).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4977      +/-   ##
==========================================
+ Coverage   47.67%   47.68%   +0.01%     
==========================================
  Files        1057     1058       +1     
  Lines       57277    57290      +13     
  Branches     3940     3942       +2     
==========================================
+ Hits        27307    27319      +12     
- Misses      29279    29280       +1     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6a4b776
packages 43.46% <100.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...web/src/chains/chain-definitions/soneium-minato.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding a new blockchain definition for `soneiumMinato` and updating the in-app wallet component to link with `Metamask` and `Passkey`.

### Detailed summary
- Added `soneiumMinato` chain definition in `packages/thirdweb/src/chains/chain-definitions/soneium-minato.ts`.
- Updated `packages/thirdweb/src/exports/chains.ts` to export `soneiumMinato`.
- Modified `apps/playground-web/src/components/in-app-wallet/profile-sections.tsx` to include buttons for linking `Metamask` and `Passkey`, replacing the `Coinbase Wallet` button.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants