Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on improving the gas estimation for zksync transactions by overestimating the gas limit to accommodate extra gas required for paymaster operations, and it adds a test case for sending transactions.

Detailed summary

  • Added a patch for thirdweb to overestimate zksync gas limit.
  • Introduced a new test case in packages/thirdweb/src/wallets/smart/smart-wallet-zksync.test.ts for sending dummy transactions.
  • Updated gas calculation in packages/thirdweb/src/transaction/actions/zksync/send-eip712-transaction.ts to double the gas limit and base fee for better transaction inclusion.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 51f2308

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:28pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:28pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:28pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:28pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 3.2 s (+22.86% 🔺) 4.1 s
thirdweb (cjs) 101.87 KB (+0.22% 🔺) 2.1 s (+0.22% 🔺) 7.1 s (+27.32% 🔺) 9.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 308 ms (+24.2% 🔺) 405 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 81 ms (-23.58% 🔽) 91 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 630 ms (-22.13% 🔽) 975 ms

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.68%. Comparing base (7c10343) to head (51f2308).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nsaction/actions/zksync/send-eip712-transaction.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4979   +/-   ##
=======================================
  Coverage   47.68%   47.68%           
=======================================
  Files        1058     1058           
  Lines       57290    57290           
  Branches     3942     3941    -1     
=======================================
+ Hits        27319    27320    +1     
+ Misses      29280    29279    -1     
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7c10343
packages 43.46% <0.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...nsaction/actions/zksync/send-eip712-transaction.ts 7.19% <0.00%> (ø)

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges merged commit ccd4cd6 into main Oct 9, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the fix_overestimate_zksync_gas_limit_for_paymaster_extra_gas branch October 9, 2024 23:35
@jnsdls jnsdls mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants