-
Notifications
You must be signed in to change notification settings - Fork 619
fix: overestimate zksync gas limit for paymaster extra gas #4979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overestimate zksync gas limit for paymaster extra gas #4979
Conversation
🦋 Changeset detectedLatest commit: 51f2308 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4979 +/- ##
=======================================
Coverage 47.68% 47.68%
=======================================
Files 1058 1058
Lines 57290 57290
Branches 3942 3941 -1
=======================================
+ Hits 27319 27320 +1
+ Misses 29280 29279 -1
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the gas estimation for
zksynctransactions by overestimating the gas limit to accommodate extra gas required for paymaster operations, and it adds a test case for sending transactions.Detailed summary
thirdwebto overestimatezksyncgas limit.packages/thirdweb/src/wallets/smart/smart-wallet-zksync.test.tsfor sending dummy transactions.packages/thirdweb/src/transaction/actions/zksync/send-eip712-transaction.tsto double the gas limit and base fee for better transaction inclusion.