Fix unhandled server error on certain deprecated chain slugs

[MananTank]

Fixes: DASH-311

---

PR-Codex overview

This PR updates the conditional check for the existence of chain.data in the utils.ts file, ensuring that both chain.data and chainServices.data are verified before proceeding to call notFound().

Detailed summary

• Modified the conditional statement to check for both chain.data and chainServices.data:
  • Changed from if (!chain.data) to if (!chain.data || !chainServices.data).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2024 4:35pm

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)			Oct 10, 2024 4:35pm
thirdweb_playground	⬜️ Skipped (Inspect)			Oct 10, 2024 4:35pm
wallet-ui	⬜️ Skipped (Inspect)			Oct 10, 2024 4:35pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: ec53366

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[MananTank]

• Fix unhandled server error on certain deprecated chain slugs #4986 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.74%. Comparing base (e7dd186) to head (ec53366).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4986   +/-   ##
=======================================
  Coverage   47.74%   47.74%           
=======================================
  Files        1059     1059           
  Lines       57328    57328           
  Branches     3944     3944           
=======================================
  Hits        27369    27369           
  Misses      29268    29268           
  Partials      691      691           

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.68% <ø> (ø)		Carriedforward from e7dd186
packages	43.53% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

[linear]

DASH-311 TypeError: Cannot read properties of undefined (reading 'services') on deprecated chain slugs - ex: /base-goerli

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.07 KB (0%)	842 ms (0%)	272 ms (+7.85% 🔺)	1.2 s
thirdweb (cjs)	101.87 KB (0%)	2.1 s (0%)	600 ms (+2.93% 🔺)	2.7 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	31 ms (+68.45% 🔺)	127 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	4 ms (-22.07% 🔽)	14 ms
thirdweb/react (minimal + tree-shaking)	17.24 KB (0%)	345 ms (0%)	59 ms (+60.59% 🔺)	404 ms

[graphite-app]

Merge activity

• Oct 10, 12:18 PM EDT: A user added this pull request to the Graphite merge queue.
• Oct 10, 12:35 PM EDT: A user merged this pull request with the Graphite merge queue.