Only Show Top wallets in Connect Analytics, merge rest to Others + Remove dynamically generated colors #4994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4994 +/- ##
=======================================
Coverage 47.76% 47.76%
=======================================
Files 1058 1058
Lines 57290 57290
Branches 3943 3943
=======================================
Hits 27364 27364
Misses 29235 29235
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
MananTank
changed the title
joaquim-verges
approved these changes
Oct 11, 2024
Contributor
Merge activity
|
MananTank
added a commit
that referenced
this pull request
Oct 11, 2024
…move dynamically generated colors (#4994) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the wallet analytics dashboard by improving the display of wallet statistics, adding new wallet types, and refining the chart configurations for better visualization of wallet usage data. ### Detailed summary - Updated `globals.css` to remove redundant CSS variables. - Added new wallet types in `storyUtils.ts`. - Adjusted container widths in several story components to a maximum width of `1150px`. - Enhanced `WalletConnectorsChartCard` to show top wallets and aggregate others. - Updated chart configuration to handle "Others" category in both `WalletConnectorsChartCard` and `WalletDistributionChartCard`. - Changed `ChartToShow` type to include `totalConnections` and `uniqueWalletsConnected`. - Modified data handling in `WalletDistributionChartCard` to aggregate wallet stats correctly. - Updated rendering logic to reflect changes in chart data and labels. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
10-11-only_show_top_10_wallets_in_connect_analytics_remove_dynamically_generated_colors
branch
from
e4745a0 to
5660ce4
Compare
…move dynamically generated colors (#4994) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the wallet analytics dashboard by improving the display of wallet statistics, adding new wallet types, and refining the chart configurations for better visualization of wallet usage data. ### Detailed summary - Updated `globals.css` to remove redundant CSS variables. - Added new wallet types in `storyUtils.ts`. - Adjusted container widths in several story components to a maximum width of `1150px`. - Enhanced `WalletConnectorsChartCard` to show top wallets and aggregate others. - Updated chart configuration to handle "Others" category in both `WalletConnectorsChartCard` and `WalletDistributionChartCard`. - Changed `ChartToShow` type to include `totalConnections` and `uniqueWalletsConnected`. - Modified data handling in `WalletDistributionChartCard` to aggregate wallet stats correctly. - Updated rendering logic to reflect changes in chart data and labels. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
10-11-only_show_top_10_wallets_in_connect_analytics_remove_dynamically_generated_colors
branch
from
5660ce4 to
79f029c
Compare
graphite-app
bot
deleted the
10-11-only_show_top_10_wallets_in_connect_analytics_remove_dynamically_generated_colors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the wallet analytics dashboard by improving styling, adding new wallet types, and modifying chart logic to better handle and display wallet data, including grouping lesser-used wallets under "Others."
Detailed summary
globals.css.storyUtils.ts.WalletConnectorsChartCard.tsxandWalletDistributionChartCard.tsxto show top wallets and group others.ChartToShowtype to reflect new metrics.