-
Notifications
You must be signed in to change notification settings - Fork 619
feat: handle zksync direct deploys in deployContract #5002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle zksync direct deploys in deployContract #5002
Conversation
🦋 Changeset detectedLatest commit: cd2c0f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
9531aa2 to
32b3a5c
Compare
size-limit report 📦
|
32b3a5c to
ec74e6d
Compare
ec74e6d to
07c3e21
Compare
07c3e21 to
6655d73
Compare
6655d73 to
20f155f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5002 +/- ##
==========================================
- Coverage 47.76% 47.72% -0.04%
==========================================
Files 1058 1059 +1
Lines 57290 57323 +33
Branches 3943 3941 -2
==========================================
- Hits 27364 27359 -5
- Misses 29235 29273 +38
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `thirdweb` library with new features and bug fixes, particularly for zkSync deployments and improvements to various ERC1155 and ERC721 modules.
### Detailed summary
- Added support for zkSync direct deploys in `deployContract`.
- Updated `SequentialTokenIdERC1155` to include `startTokenId` in its module.
- Modified event signatures for `BatchMetadataUpdate` in both ERC721 and ERC1155.
- Increased test retry count and max concurrency in `vitest.config.ts`.
- Introduced new methods for batch metadata handling, including `getBatchIndex` and `getMetadataBatch`.
- Added `setBaseURI` functionality for both `BatchMetadataERC721` and `BatchMetadataERC1155`.
- Created parameter encoding functions for `updateTokenIdERC1155`.
- Enhanced error handling and configuration retrieval methods in modules.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
20f155f to
cd2c0f3
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
thirdwebmodule by introducing support for zkSync direct deployments in thedeployContractfunction and updating various module configurations and functions to accommodate new parameters and features.Detailed summary
deployContract.SequentialTokenIdERC1155to includestartTokenIdin its module.BatchMetadataUpdatein bothBatchMetadataERC721andBatchMetadataERC1155.vitest.config.ts.SequentialTokenIdERC1155andBatchMetadataERC721.getBatchIndexandgetMetadataBatchfunctions with their respective parameters and encoding methods.setBaseURIfunctions for bothBatchMetadataERC721andBatchMetadataERC1155.