feat: handle zksync direct deploys in deployContract #5002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd2c0f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
joaquim-verges
force-pushed
the
feat_handle_zksync_direct_deploys_in_deployContract
branch
from
9531aa2 to
32b3a5c
Compare
Contributor
size-limit report 📦
|
jnsdls
requested changes
Oct 13, 2024
gregfromstl
approved these changes
Oct 13, 2024
joaquim-verges
force-pushed
the
feat_handle_zksync_direct_deploys_in_deployContract
branch
from
32b3a5c to
ec74e6d
Compare
jnsdls
approved these changes
Oct 13, 2024
joaquim-verges
force-pushed
the
feat_handle_zksync_direct_deploys_in_deployContract
branch
from
ec74e6d to
07c3e21
Compare
joaquim-verges
force-pushed
the
feat_handle_zksync_direct_deploys_in_deployContract
branch
from
07c3e21 to
6655d73
Compare
joaquim-verges
force-pushed
the
feat_handle_zksync_direct_deploys_in_deployContract
branch
from
6655d73 to
20f155f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5002 +/- ##
==========================================
- Coverage 47.76% 47.72% -0.04%
==========================================
Files 1058 1059 +1
Lines 57290 57323 +33
Branches 3943 3941 -2
==========================================
- Hits 27364 27359 -5
- Misses 29235 29273 +38
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `thirdweb` library with new features and bug fixes, particularly for zkSync deployments and improvements to various ERC1155 and ERC721 modules.
### Detailed summary
- Added support for zkSync direct deploys in `deployContract`.
- Updated `SequentialTokenIdERC1155` to include `startTokenId` in its module.
- Modified event signatures for `BatchMetadataUpdate` in both ERC721 and ERC1155.
- Increased test retry count and max concurrency in `vitest.config.ts`.
- Introduced new methods for batch metadata handling, including `getBatchIndex` and `getMetadataBatch`.
- Added `setBaseURI` functionality for both `BatchMetadataERC721` and `BatchMetadataERC1155`.
- Created parameter encoding functions for `updateTokenIdERC1155`.
- Enhanced error handling and configuration retrieval methods in modules.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
feat_handle_zksync_direct_deploys_in_deployContract
branch
from
20f155f to
cd2c0f3
Compare
graphite-app
bot
deleted the
feat_handle_zksync_direct_deploys_in_deployContract
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
thirdwebmodule by introducing support for zkSync direct deployments in thedeployContractfunction and updating various module configurations and functions to accommodate new parameters and features.Detailed summary
deployContract.SequentialTokenIdERC1155to includestartTokenIdin its module.BatchMetadataUpdatein bothBatchMetadataERC721andBatchMetadataERC1155.vitest.config.ts.SequentialTokenIdERC1155andBatchMetadataERC721.getBatchIndexandgetMetadataBatchfunctions with their respective parameters and encoding methods.setBaseURIfunctions for bothBatchMetadataERC721andBatchMetadataERC1155.