Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 13, 2024

Problem solved

Fixes CNCT-2068


PR-Codex overview

This PR introduces an enhancement to the useConnectModal by exposing authentication options that allow users to utilize Sign in with Ethereum (SIWE) for added security during wallet connections.

Detailed summary

  • Added auth property to UseConnectModalOptions type.
  • auth accepts an object of type SiweAuthOptions for user authentication.
  • Updated documentation to reference SiweAuthOptions with a link for further details.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 7:53am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 7:53am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 7:53am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 7:53am

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2024

🦋 Changeset detected

Latest commit: dcd572c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 13, 2024 07:42
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 503 ms (-16.41% 🔽) 1.4 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 1.5 s (-13.56% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 57 ms (+55.4% 🔺) 154 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 29 ms (+100% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 135 ms (-5.18% 🔽) 480 ms

@linear
Copy link

linear bot commented Oct 13, 2024

@codecov
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.74%. Comparing base (cd2c0f3) to head (dcd572c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5004      +/-   ##
==========================================
+ Coverage   47.72%   47.74%   +0.02%     
==========================================
  Files        1059     1058       -1     
  Lines       57323    57285      -38     
  Branches     3941     3941              
==========================================
- Hits        27359    27353       -6     
+ Misses      29273    29241      -32     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cd2c0f3
packages 43.54% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit df0388d into main Oct 13, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the feat_expose_auth_options_on_useConnectModal branch October 13, 2024 20:12
@jnsdls jnsdls mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants