Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Oct 15, 2024

PR-Codex overview

This PR primarily focuses on replacing the usage of react-icons with lucide-react icons across various components in the application, enhancing consistency and potentially improving performance.

Detailed summary

  • Removed react-icons and replaced with lucide-react icons in multiple components.
  • Updated icon imports in EditPage, SponsorshipPolicies, GuideShowcase, and more.
  • Modified the GithubButtonLink to use a custom GithubIcon.
  • Adjusted the BillingHeader to include a new icon rendering logic.
  • Enhanced visual elements in ContractPermission, EditProfile, and Proposal components with new icons.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:29pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:29pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:29pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:29pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 60a80ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls marked this pull request as ready for review October 15, 2024 05:05
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 15, 2024
@jnsdls jnsdls requested a review from MananTank as a code owner October 15, 2024 05:05
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 15, 2024
Copy link
Member Author

jnsdls commented Oct 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (8247448) to head (60a80ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5031   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54707    54707           
  Branches     3954     3954           
=======================================
  Hits        24786    24786           
  Misses      29230    29230           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8247448
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 255 ms (+32.32% 🔺) 1.2 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 450 ms (+4.98% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 31 ms (+141.37% 🔺) 128 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 66 ms (+425.38% 🔺) 76 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 67 ms (+69.85% 🔺) 414 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on replacing instances of `react-icons` with `lucide-react` icons across various components in the application, enhancing the icon usage consistency and potentially improving performance.

### Detailed summary
- Removed `react-icons` in favor of `lucide-react` icons in multiple components.
- Updated imports and icon usage in `EditPage`, `SponsorshipPolicies`, `GuideShowcase`, `InstalledModulesTable`, and others.
- Added a new `GithubIcon` component in `GithubButtonLink`.
- Modified the `StatusCheck` component to use `lucide-react` icons for status representation.
- Adjusted icon properties and classes for better styling and consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants