[SDK] ERC1155 extension: mintToBatch #5032

kien-ngo · 2024-10-15T06:30:29Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces the mintToBatch function as an ERC1155 extension, allowing multiple tokens to be minted in a single transaction. It includes tests to ensure functionality and updates exports accordingly.

Detailed summary

Added mintToBatch function in mintToBatch.ts.
Introduced MintToBatchParams type defining minting parameters.
Created tests for mintToBatch in mintToBatch.test.ts.
Updated exports in erc1155.ts to include mintToBatch.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-15T06:30:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 8:27am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 8:27am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 8:27am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 8:27am

changeset-bot · 2024-10-15T06:30:34Z

🦋 Changeset detected

Latest commit: 3fe33a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
thirdweb	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2024-10-15T06:30:35Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-10-15T06:30:45Z

[SDK] ERC1155 extension: mintToBatch #5032 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-10-15T06:34:00Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.77 KB (0%)	856 ms (0%)	421 ms (+96.28% 🔺)	1.3 s
thirdweb (cjs)	102.62 KB (0%)	2.1 s (0%)	526 ms (+23.12% 🔺)	2.6 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	65 ms (+295.82% 🔺)	162 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	59 ms (+813.55% 🔺)	69 ms
thirdweb/react (minimal + tree-shaking)	17.35 KB (0%)	347 ms (0%)	122 ms (+346.19% 🔺)	469 ms

codecov · 2024-10-15T06:36:26Z

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (1994d9e) to head (3fe33a6).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...irdweb/src/extensions/erc1155/write/mintToBatch.ts	82.85%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5032      +/-   ##
==========================================
+ Coverage   45.28%   45.30%   +0.02%     
==========================================
  Files        1058     1059       +1     
  Lines       54672    54707      +35     
  Branches     3950     3954       +4     
==========================================
+ Hits        24758    24786      +28     
- Misses      29223    29230       +7     
  Partials      691      691

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 1994d9e
packages	`40.24% <82.85%> (+0.03%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...irdweb/src/extensions/erc1155/write/mintToBatch.ts	`82.85% <82.85%> (ø)`

... and 1 file with indirect coverage changes

joaquim-verges · 2024-10-15T06:56:28Z

packages/thirdweb/src/extensions/erc1155/write/mintToBatch.ts

+  }>;
+}>;
+
+export function mintToBatch(


add TS doc

also make sure you add a comment about the size of the batch - should not be too big otherwise it will not fit / not be included in a block

ty ser. was waiting for a review on the code before I add the docs, seems all good!

graphite-app · 2024-10-15T08:11:19Z

Merge activity

Oct 15, 4:11 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 15, 4:20 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
Oct 15, 5:03 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 15, 5:04 AM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR adds the `mintToBatch` function to the `ERC1155` extension, allowing multiple tokens to be minted in a single transaction. It includes new tests to ensure the functionality works as expected. ### Detailed summary - Introduced `mintToBatch` function in `mintToBatch.ts`. - Added `MintToBatchParams` type definition. - Updated `erc1155.ts` to export `mintToBatch` and `MintToBatchParams`. - Created tests for `mintToBatch` in `mintToBatch.test.ts` to validate minting multiple tokens. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

github-actions bot added the packages label Oct 15, 2024

kien-ngo changed the title ~~Update~~ [SDK] ERC1155 extension: mintToBatch Oct 15, 2024

kien-ngo marked this pull request as ready for review October 15, 2024 06:30

kien-ngo requested review from gregfromstl, jnsdls and joaquim-verges as code owners October 15, 2024 06:30

vercel bot deployed to Preview – wallet-ui October 15, 2024 06:33 View deployment

vercel bot deployed to Preview – thirdweb_playground October 15, 2024 06:33 View deployment

vercel bot deployed to Preview – thirdweb-www October 15, 2024 06:40 View deployment

vercel bot deployed to Preview – docs-v2 October 15, 2024 06:42 View deployment

joaquim-verges reviewed Oct 15, 2024

View reviewed changes

kien-ngo force-pushed the kien/erc1155-mintToBatch branch from 9733a91 to 89515e5 Compare October 15, 2024 07:22

vercel bot deployed to Preview – wallet-ui October 15, 2024 07:24 View deployment

vercel bot deployed to Preview – thirdweb_playground October 15, 2024 07:24 View deployment

kien-ngo force-pushed the kien/erc1155-mintToBatch branch from 89515e5 to fb69765 Compare October 15, 2024 07:28

kien-ngo requested a review from joaquim-verges October 15, 2024 07:30

vercel bot deployed to Preview – wallet-ui October 15, 2024 07:30 View deployment

vercel bot deployed to Preview – thirdweb_playground October 15, 2024 07:31 View deployment

vercel bot deployed to Preview – thirdweb-www October 15, 2024 07:39 View deployment

vercel bot deployed to Preview – docs-v2 October 15, 2024 07:44 View deployment

joaquim-verges approved these changes Oct 15, 2024

View reviewed changes

kien-ngo force-pushed the kien/erc1155-mintToBatch branch from fb69765 to 3fe33a6 Compare October 15, 2024 08:14

vercel bot deployed to Preview – wallet-ui October 15, 2024 08:18 View deployment

vercel bot deployed to Preview – thirdweb_playground October 15, 2024 08:18 View deployment

vercel bot deployed to Preview – docs-v2 October 15, 2024 08:27 View deployment

vercel bot deployed to Preview – thirdweb-www October 15, 2024 08:27 View deployment

graphite-app bot merged commit 3fe33a6 into main Oct 15, 2024
31 checks passed

graphite-app bot deleted the kien/erc1155-mintToBatch branch October 15, 2024 09:04

jnsdls mentioned this pull request Oct 15, 2024

Version Packages #5030

Merged

vercel bot deployed to Production – wallet-ui October 15, 2024 09:07 View deployment

vercel bot deployed to Production – thirdweb_playground October 15, 2024 09:07 View deployment

vercel bot deployed to Production – docs-v2 October 15, 2024 09:07 View deployment

vercel bot deployed to Production – thirdweb-www October 15, 2024 09:14 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] ERC1155 extension: mintToBatch #5032

[SDK] ERC1155 extension: mintToBatch #5032

kien-ngo commented Oct 15, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 15, 2024

Uh oh!

kien-ngo commented Oct 15, 2024

Uh oh!

github-actions bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

joaquim-verges Oct 15, 2024

Uh oh!

kien-ngo Oct 15, 2024

Uh oh!

graphite-app bot commented Oct 15, 2024 •

edited by kien-ngo

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] ERC1155 extension: mintToBatch #5032

[SDK] ERC1155 extension: mintToBatch #5032

Conversation

kien-ngo commented Oct 15, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Oct 15, 2024

Uh oh!

github-actions bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joaquim-verges Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

kien-ngo Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 15, 2024 • edited by kien-ngo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Oct 15, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 15, 2024 •

edited

Loading

changeset-bot bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

codecov bot commented Oct 15, 2024 •

edited

Loading

graphite-app bot commented Oct 15, 2024 •

edited by kien-ngo

Loading