Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 16, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the Sentry configuration in the next.config.js file and updating the turbo.json file to include an environment variable for SENTRY_AUTH_TOKEN.

Detailed summary

  • Added env: ["SENTRY_AUTH_TOKEN"] in turbo.json.
  • Updated wSentry configuration in apps/dashboard/next.config.js:
    • Added authToken: process.env.SENTRY_AUTH_TOKEN.
    • Changed silent from true to false.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 85e7d15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:27pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:27pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:27pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:27pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 16, 2024
@MananTank MananTank marked this pull request as ready for review October 16, 2024 19:26
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (3a141e7) to head (85e7d15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5056   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54724    54724           
  Branches     3953     3953           
=======================================
  Hits        24786    24786           
  Misses      29247    29247           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3a141e7
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 2.9 s (+31.3% 🔺) 3.7 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 6.9 s (+0.7% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 119 ms (-38.9% 🔽) 215 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 102 ms (+55.88% 🔺) 112 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 426 ms (-38.78% 🔽) 773 ms

@MananTank MananTank force-pushed the 10-17-add_sentry_auth_token_to_fix_sourcemaps branch from ddf7d0b to 39053f7 Compare October 16, 2024 19:31
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 16, 2024 19:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2024 19:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2024 19:31 Inactive
@MananTank MananTank changed the title Add Sentry auth token to fix sourcemaps Fix sourcemaps in Sentry for dashboard Oct 16, 2024
Copy link
Member Author

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the configuration for `Sentry` in the `next.config.js` file and modifies the `turbo.json` to include an environment variable for `SENTRY_AUTH_TOKEN`. It also refines the `Sentry` setup options for better functionality and logging.

### Detailed summary
- Added `"env": ["SENTRY_AUTH_TOKEN"]` to `turbo.json`.
- Updated `Sentry` configuration in `apps/dashboard/next.config.js`:
  - Changed `silent` from `true` to `false`.
  - Added `authToken: process.env.SENTRY_AUTH_TOKEN`.
- Retained other `Sentry` options with no changes.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants