Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the handling of zkSync chains, enhancing user messaging in the UI, enforcing a minimum gas limit for transactions, and adding tests for interactions with the Treasure Topaz Testnet.

Detailed summary

  • Updated isZkSyncChain.ts to include chain.id 978658.
  • Modified UI text in sponsored-tx.tsx and sponsored-tx-zksync.tsx to append "Kittens" to the NFT ownership message.
  • Enforced a minimum gas limit of 50000n in send-eip712-transaction.ts.
  • Added a test case for sending transactions on the Treasure Topaz Testnet in smart-wallet-zksync.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:50am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:50am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:50am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:50am

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 93798ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 17, 2024 00:35
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title feat: add new zksync chain ID feat: updatez chains Oct 17, 2024
@joaquim-verges joaquim-verges changed the title feat: updatez chains chore: update chains Oct 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 286 ms (-34.75% 🔽) 1.2 s
thirdweb (cjs) 102.53 KB (-0.09% 🔽) 2.1 s (-0.09% 🔽) 842 ms (-12.11% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 87 ms (+368.21% 🔺) 184 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 31 ms (+302.78% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 202 ms (+130.54% 🔺) 549 ms

@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.27%. Comparing base (cb64067) to head (93798ec).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...nsaction/actions/zksync/send-eip712-transaction.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5059      +/-   ##
==========================================
- Coverage   45.30%   45.27%   -0.03%     
==========================================
  Files        1059     1060       +1     
  Lines       54714    54756      +42     
  Branches     3953     3955       +2     
==========================================
+ Hits        24786    24792       +6     
- Misses      29237    29273      +36     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cb64067
packages 40.21% <40.00%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...thirdweb/src/utils/any-evm/zksync/isZkSyncChain.ts 80.76% <100.00%> (+0.76%) ⬆️
...nsaction/actions/zksync/send-eip712-transaction.ts 0.75% <0.00%> (-0.02%) ⬇️

... and 6 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit cb6a053 into main Oct 17, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the feat_add_new_zksync_chain_ID branch October 17, 2024 03:41
@jnsdls jnsdls mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants