Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on improving the URL construction for the href attribute in the metadata-header.tsx component by ensuring that a trailing slash is included when necessary.

Detailed summary

  • Updated the href construction for validBlockExplorer.url to check if it ends with a /.
  • If it does not end with a /, it appends one before adding the address/${address} segment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 5:48am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 17, 2024 5:48am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 17, 2024 5:48am
wallet-ui ⬜️ Skipped (Inspect) Oct 17, 2024 5:48am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 05:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 05:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 05:34 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 63037f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 17, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges marked this pull request as ready for review October 17, 2024 05:35
@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (b205f1d) to head (63037f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5061   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54728    54728           
  Branches     3954     3954           
=======================================
  Hits        24791    24791           
  Misses      29246    29246           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b205f1d
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 197 ms (-36.77% 🔽) 1.1 s
thirdweb (cjs) 102.53 KB (0%) 2.1 s (0%) 447 ms (-10% 🔽) 2.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 15 ms (-20.55% 🔽) 112 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 17 ms (+374.76% 🔺) 27 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 132 ms (+196.37% 🔺) 479 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 17, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `href` attribute in the `metadata-header.tsx` file to ensure that the URL for the block explorer correctly appends the address, handling cases where the URL may or may not end with a trailing slash.

### Detailed summary
- Modified the `href` attribute to check if `validBlockExplorer.url` ends with a `/`.
- If it does not, a `/` is added before appending `address/${address}`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the fix_ensure_valid_block_explorer_URL_for_address_links branch from d5edbbf to 63037f1 Compare October 17, 2024 05:45
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 05:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 05:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 05:45 Inactive
@graphite-app graphite-app bot merged commit 63037f1 into main Oct 17, 2024
30 checks passed
@graphite-app graphite-app bot deleted the fix_ensure_valid_block_explorer_URL_for_address_links branch October 17, 2024 05:48
@vercel vercel bot temporarily deployed to Production – docs-v2 October 17, 2024 05:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 17, 2024 05:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 17, 2024 05:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants