-
Notifications
You must be signed in to change notification settings - Fork 621
fix: ensure valid block explorer URL for address links #5061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure valid block explorer URL for address links #5061
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5061 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 1059 1059
Lines 54728 54728
Branches 3954 3954
=======================================
Hits 24791 24791
Misses 29246 29246
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the `href` attribute in the `metadata-header.tsx` file to ensure that the URL for the block explorer correctly appends the address, handling cases where the URL may or may not end with a trailing slash.
### Detailed summary
- Modified the `href` attribute to check if `validBlockExplorer.url` ends with a `/`.
- If it does not, a `/` is added before appending `address/${address}`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
d5edbbf to
63037f1
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the URL construction for the
hrefattribute in themetadata-header.tsxcomponent by ensuring that a trailing slash is included when necessary.Detailed summary
hrefconstruction forvalidBlockExplorer.urlto check if it ends with a/./, it appends one before adding theaddress/${address}segment.