Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 21, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on ensuring that smart accounts are deployed before validating signatures in the thirdweb package. It introduces a new function to confirm contract deployment and updates tests to validate the deployment process.

Detailed summary

  • Added a test case in smart-wallet-dev.test.ts to check if a smart account can sign a message after deployment.
  • Introduced confirmContractDeployment function to verify that the smart account contract is deployed before proceeding.
  • Included comments to handle synchronization issues between the bundler and RPC during contract deployment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: e0134c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:16am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:16am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:16am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:16am

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title test: enable SmartWallet policy tests fix: ensure smart accounts are deployed before validating signatures Oct 21, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review October 21, 2024 09:38
@joaquim-verges joaquim-verges force-pushed the test_enable_SmartWallet_policy_tests branch from cd1214c to c6621dc Compare October 21, 2024 09:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 361 ms (+50.94% 🔺) 1.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 694 ms (+14.65% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 17 ms (+42.89% 🔺) 114 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 8 ms (-6.92% 🔽) 18 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 88 ms (+129.34% 🔺) 435 ms

@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (df128bf) to head (e0134c6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/smart/index.ts 52.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5092   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54729    54754   +25     
  Branches     3956     3958    +2     
=======================================
+ Hits        24789    24803   +14     
- Misses      29249    29260   +11     
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from df128bf
packages 40.24% <52.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/index.ts 63.46% <52.00%> (-0.64%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants